Merge branch 'refactor-init' into refactor-impressions-tracker

EmilianoSanchez · EmilianoSanchez · commit 970a5a36e969 · 2026-03-11T18:14:32.000-03:00
diff --git a/src/dtos/types.ts b/src/dtos/types.ts
@@ -41,10 +41,10 @@ export interface IDependencyMatcherData {
 
 interface ISplitMatcherBase {
   matcherType: string
-  negate: boolean
-  keySelector: null | {
+  negate?: boolean
+  keySelector?: null | {
     trafficType: string,
-    attribute: string | null
+    attribute?: string | null
   }
   userDefinedSegmentMatcherData?: null | IInSegmentMatcherData
   userDefinedLargeSegmentMatcherData?: null | IInLargeSegmentMatcherData
@@ -207,7 +207,7 @@ export interface IExcludedSegment {
 export interface IRBSegment {
   name: string,
   changeNumber: number,
-  status: 'ACTIVE' | 'ARCHIVED',
+  status?: 'ACTIVE' | 'ARCHIVED',
   conditions?: ISplitCondition[] | null,
   excluded?: {
     keys?: string[] | null,
@@ -218,7 +218,7 @@ export interface IRBSegment {
 export interface ISplit {
   name: string,
   changeNumber: number,
-  status: 'ACTIVE' | 'ARCHIVED',
+  status?: 'ACTIVE' | 'ARCHIVED',
   conditions: ISplitCondition[],
   prerequisites?: null | {
     n: string,
diff --git a/src/evaluator/types.ts b/src/evaluator/types.ts
@@ -13,8 +13,8 @@ export interface IMatcherDto {
   name: string
   value?: string | number | boolean | string[] | IDependencyMatcherData | IBetweenMatcherData | IBetweenStringMatcherData | null
 
-  attribute: string | null
-  negate: boolean
+  attribute?: string | null
+  negate?: boolean
   dataType: string
 }
 
diff --git a/src/evaluator/value/index.ts b/src/evaluator/value/index.ts
@@ -4,7 +4,7 @@ import { ILogger } from '../../logger/types';
 import { sanitize } from './sanitize';
 import { ENGINE_VALUE, ENGINE_VALUE_NO_ATTRIBUTES, ENGINE_VALUE_INVALID } from '../../logger/constants';
 
-function parseValue(log: ILogger, key: SplitIO.SplitKey, attributeName: string | null, attributes?: SplitIO.Attributes) {
+function parseValue(log: ILogger, key: SplitIO.SplitKey, attributeName?: string | null, attributes?: SplitIO.Attributes) {
   let value = undefined;
   if (attributeName) {
     if (attributes) {
diff --git a/src/sync/polling/updaters/splitChangesUpdater.ts b/src/sync/polling/updaters/splitChangesUpdater.ts
@@ -90,7 +90,7 @@ function matchFilters(featureFlag: ISplit, filters: ISplitFiltersValidation) {
 export function computeMutation<T extends ISplit | IRBSegment>(rules: Array<T>, segments: Set<string>, filters?: ISplitFiltersValidation): ISplitMutations<T> {
 
   return rules.reduce((accum, ruleEntity) => {
-    if (ruleEntity.status === 'ACTIVE' && (!filters || matchFilters(ruleEntity as ISplit, filters))) {
+    if (ruleEntity.status !== 'ARCHIVED' && (!filters || matchFilters(ruleEntity as ISplit, filters))) {
       accum.added.push(ruleEntity);
 
       parseSegments(ruleEntity).forEach((segmentName: string) => {

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,8 @@ export interface IMatcherDto {`
`13`	`13`	`name: string`
`14`	`14`	`value?: string \| number \| boolean \| string[] \| IDependencyMatcherData \| IBetweenMatcherData \| IBetweenStringMatcherData \| null`
`15`	`15`
`16`		`- attribute: string \| null`
`17`		`- negate: boolean`
	`16`	`+ attribute?: string \| null`
	`17`	`+ negate?: boolean`
`18`	`18`	`dataType: string`
`19`	`19`	`}`
`20`	`20`