updated ci/cd workflow. And added a missing assert in E2E test

EmilianoSanchez · EmilianoSanchez · commit 44943e823af0 · 2022-07-22T15:08:47.000-03:00
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -50,8 +50,9 @@ jobs:
       - name: npm Build
         run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
 
-      - name: npm Build GaToSplit auto-require script
-        run: npm run build:ga-to-split-autorequire
+      # Uncomment to upload auto-require script to S3
+      # - name: npm Build GaToSplit auto-require script
+      #   run: npm run build:ga-to-split-autorequire
 
       - name: Configure AWS credentials (development)
         if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/development' }}
diff --git a/src/__tests__/browserSuites/push-synchronization.spec.js b/src/__tests__/browserSuites/push-synchronization.spec.js
@@ -94,7 +94,7 @@ const MILLIS_UNLOAD_BROWSER_EVENT = 1700;
  *  1.7 secs: 'unload' browser event -> streaming connection closed
  */
 export function testSynchronization(fetchMock, assert) {
-  assert.plan(36);
+  assert.plan(38);
   fetchMock.reset();
 
   let start, splitio, client, otherClient, keylistAddClient, keylistRemoveClient, bitmapTrueClient, sharedClients = [];
@@ -135,11 +135,14 @@ export function testSynchronization(fetchMock, assert) {
 
     setTimeout(() => {
       assert.equal(client.getTreatment('whitelist'), 'allowed', 'evaluation with not killed Split');
-      client.once(client.Event.SDK_UPDATE, () => {
+      const onUpdateCb = () => {
         const lapse = Date.now() - start;
         assert.true(nearlyEqual(lapse, MILLIS_SPLIT_KILL_EVENT), 'SDK_UPDATE due to SPLIT_KILL event');
         assert.equal(client.getTreatment('whitelist'), 'not_allowed', 'evaluation with killed Split');
-      });
+      };
+      // SPLIT_KILL triggers two SDK_UPDATE events. The 1st due to `killLocally` and the 2nd due to `/splitChanges` fetch
+      client.once(client.Event.SDK_UPDATE, onUpdateCb);
+      client.once(client.Event.SDK_UPDATE, onUpdateCb);
       eventSourceInstance.emitMessage(splitKillMessage);
     }, MILLIS_SPLIT_KILL_EVENT); // send a SPLIT_KILL event with a new changeNumber after 0.5 seconds
 
diff --git a/src/__tests__/nodeSuites/push-synchronization.spec.js b/src/__tests__/nodeSuites/push-synchronization.spec.js
@@ -57,7 +57,7 @@ const MILLIS_DESTROY = 700;
  *  0.6 secs: SPLIT_UPDATE event with new segments -> /splitChanges, /segmentChanges/{newSegments}
  */
 export function testSynchronization(fetchMock, assert) {
-  assert.plan(22);
+  assert.plan(24);
   fetchMock.reset();
   __setEventSource(EventSourceMock);
 
@@ -102,11 +102,14 @@ export function testSynchronization(fetchMock, assert) {
     }, MILLIS_SEGMENT_UPDATE_EVENT); // send a SEGMENT_UPDATE event with a new changeNumber after 0.4 seconds
     setTimeout(() => {
       assert.equal(client.getTreatment(key, 'whitelist'), 'allowed', 'evaluation with not killed Split');
-      client.once(client.Event.SDK_UPDATE, () => {
+      const onUpdateCb = () => {
         const lapse = Date.now() - start;
         assert.true(nearlyEqual(lapse, MILLIS_SPLIT_KILL_EVENT), 'SDK_UPDATE due to SPLIT_KILL event');
         assert.equal(client.getTreatment(key, 'whitelist'), 'not_allowed', 'evaluation with killed Split');
-      });
+      };
+      // SPLIT_KILL triggers two SDK_UPDATE events. The 1st due to `killLocally` and the 2nd due to `/splitChanges` fetch
+      client.once(client.Event.SDK_UPDATE, onUpdateCb);
+      client.once(client.Event.SDK_UPDATE, onUpdateCb);
       eventSourceInstance.emitMessage(splitKillMessage);
     }, MILLIS_SPLIT_KILL_EVENT); // send a SPLIT_KILL event with a new changeNumber after 0.5 seconds
     setTimeout(() => {
