Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: splitio/java-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: splitio/java-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: continued-modularization_3-2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 161 files changed
  • 1 contributor

Commits on Apr 1, 2026

  1. WIP evaluator

    AI-Session-Id: 095253e8-7e1c-4578-9779-bf96395021cf
    AI-Tool: claude-code
    AI-Model: unknown
    gthea committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    68731e9 View commit details
    Browse the repository at this point in the history
  2. Targeting rule evaluator

    AI-Session-Id: 095253e8-7e1c-4578-9779-bf96395021cf
    AI-Tool: claude-code
    AI-Model: unknown
    gthea committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    0a24b56 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2026

  1. PR 1.1 — Tidy: Make ExcludedSegments constants public for cross-modul…

    …e access
    
    Make STANDARD_TYPE and RULE_BASED_TYPE public so they are accessible
    from parsing-commons once that module is extracted.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    62ce66a View commit details
    Browse the repository at this point in the history
  2. PR 1.2 — Extract: Create parsing-commons module

    Move 18 DTOs from client/dtos, ParsedCondition + ParserUtils from
    engine/experiments, and Labels from engine/evaluator into a new
    parsing-commons module. Add targeting-engine as its only dependency.
    Add parsing-commons dep to client/pom.xml and register module in root pom.xml.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    0fd9305 View commit details
    Browse the repository at this point in the history
  3. PR 1.3 — Wire: Verify transitive consumers for parsing-commons

    Audited pluggable-storage, redis-wrapper, and testing modules.
    None import the moved DTOs, ParserUtils, ParsedCondition, or Labels
    directly — no additional dependency changes required.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    066a22c View commit details
    Browse the repository at this point in the history
  4. Fix PR 1.2 — Remove moved DTOs from client after extraction to parsin…

    …g-commons
    
    The git mv deletions were not staged in the original PR 1.2 commit due to
    a stash/pop mishap. This commit removes the 21 files from client/ that were
    moved to parsing-commons.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    665f1e6 View commit details
    Browse the repository at this point in the history
  5. PR 2.1 — Tidy: Replace Guava Maps.newConcurrentMap() in RuleBasedSegm…

    …entCacheInMemoryImp
    
    Replace com.google.common.collect.Maps.newConcurrentMap() with
    new ConcurrentHashMap<>() so this class can be extracted to
    storage-commons without a Guava dependency.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    55f5e74 View commit details
    Browse the repository at this point in the history
  6. PR 2.2 — Extract: Create storage-commons module

    Move 3 RuleBasedSegment cache interfaces, 1 in-memory impl, RuleBasedSegmentParser,
    ParsedRuleBasedSegment, and RuleBasedSegment DTO into new storage-commons module.
    Depends on parsing-commons and slf4j. Add storage-commons dep to client/pom.xml.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    5d1f548 View commit details
    Browse the repository at this point in the history
  7. PR 2.3 — Wire: Verify transitive consumers for storage-commons

    Audited pluggable-storage, redis-wrapper, and testing modules.
    None import RuleBasedSegment cache interfaces, ParsedRuleBasedSegment,
    RuleBasedSegmentParser, or RuleBasedSegment DTO directly.
    No additional dependency changes required.
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    c06660f View commit details
    Browse the repository at this point in the history
  8. PR 3.1 — Tidy: Extract narrow interfaces for segment-commons

    - Add ExecutorFactory, TelemetryListener, DefinitionsCacheConsumer interfaces
    - Refactor SegmentFetcherImp and SegmentSynchronizationTaskImp to use them
    - Remove Guava dependencies from segment classes
    - Update SplitFactoryImpl and all affected tests
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    45065b0 View commit details
    Browse the repository at this point in the history
  9. PR 3.2 — Extract: Create segment-commons module

    - New segment-commons module with 16 files moved from client:
      - engine/segments: SegmentFetcher, SegmentChangeFetcher, SegmentFetcherImp,
        SegmentImp, SegmentSynchronizationTask, SegmentSynchronizationTaskImp,
        ExecutorFactory, TelemetryListener
      - storages: SegmentCache, SegmentCacheCommons, SegmentCacheConsumer,
        SegmentCacheProducer, DefinitionsCacheConsumer
      - storages/memory: SegmentCacheInMemoryImpl
      - client/dtos: SegmentChange
      - engine/common: FetchOptions
      - engine/experiments: SyncTask
    - Remove Guava from SegmentCacheInMemoryImpl and FetchOptions
    - Add segment-commons dependency to client/pom.xml
    gthea committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    e7190bf View commit details
    Browse the repository at this point in the history
Loading