refactor: extract TargetingRuleFactory from ParsedSplit

gthea · gthea · commit fb7b1ae66cde · 2026-04-08T12:53:14.000-03:00
- Create TargetingRuleFactory with static buildTargetingRule() method
- Eliminate FQNs for io.split.rules.model types
- Add comprehensive tests for factory methods
- Update ParsedSplit to delegate to factory

This improves testability and separation of concerns by isolating
the mapping logic from SDK domain objects to targeting-engine objects.

AI-Session-Id: 7d0b171a-a576-4317-965f-99fb98c11ba8
AI-Tool: claude-code
AI-Model: unknown
diff --git a/client/src/main/java/io/split/engine/experiments/ParsedSplit.java b/client/src/main/java/io/split/engine/experiments/ParsedSplit.java
@@ -68,7 +68,7 @@ public static ParsedSplit createParsedSplitForTests(
                 flagSets,
                 impressionsDisabled,
                 prerequisitesMatcher,
-                buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
+                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
                         changeNumber, 100, seed, algo, null, flagSets, impressionsDisabled, prerequisitesMatcher)
         );
     }
@@ -102,7 +102,7 @@ public static ParsedSplit createParsedSplitForTests(
                 flagSets,
                 impressionsDisabled,
                 prerequisitesMatcher,
-                buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
+                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
                         changeNumber, 100, seed, algo, configurations, flagSets, impressionsDisabled, prerequisitesMatcher)
         );
     }
@@ -126,7 +126,7 @@ public ParsedSplit(
         this(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName, changeNumber,
                 trafficAllocation, trafficAllocationSeed, algo, configurations, flagSets,
                 impressionsDisabled, prerequisitesMatcher,
-                buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
+                TargetingRuleFactory.buildTargetingRule(feature, seed, killed, defaultTreatment, matcherAndSplits, trafficTypeName,
                         changeNumber, trafficAllocation, trafficAllocationSeed, algo, configurations,
                         flagSets, impressionsDisabled, prerequisitesMatcher));
     }
@@ -284,39 +284,6 @@ public String toString() {
 
     }
 
-    private static TargetingRule buildTargetingRule(
-            String feature, int seed, boolean killed, String defaultTreatment,
-            List<ParsedCondition> matcherAndSplits, String trafficTypeName, long changeNumber,
-            int trafficAllocation, int trafficAllocationSeed, int algo,
-            Map<String, String> configurations, HashSet<String> flagSets,
-            boolean impressionsDisabled, PrerequisitesMatcher prerequisitesMatcher) {
-        List<io.split.rules.model.Condition> conditions = matcherAndSplits == null
-                ? Collections.<io.split.rules.model.Condition>emptyList()
-                : matcherAndSplits.stream()
-                        .map(ParsedSplit::toTargetingCondition)
-                        .collect(Collectors.toList());
-        List<io.split.rules.model.Prerequisite> prereqs = prerequisitesMatcher == null
-                ? Collections.<io.split.rules.model.Prerequisite>emptyList()
-                : prerequisitesMatcher.getPrerequisites() == null
-                        ? Collections.<io.split.rules.model.Prerequisite>emptyList()
-                        : Collections.unmodifiableList(prerequisitesMatcher.getPrerequisites());
-        return new TargetingRule(feature, seed, killed, defaultTreatment, conditions, trafficTypeName,
-                changeNumber, trafficAllocation, trafficAllocationSeed, algo, configurations,
-                flagSets == null ? new HashSet<>() : flagSets, impressionsDisabled, prereqs);
-    }
-
-    private static io.split.rules.model.Condition toTargetingCondition(ParsedCondition c) {
-        List<io.split.rules.model.Partition> partitions = c.partitions() == null
-                ? Collections.<io.split.rules.model.Partition>emptyList()
-                : c.partitions().stream()
-                        .map(p -> new io.split.rules.model.Partition(p.treatment, p.size))
-                        .collect(Collectors.toList());
-        io.split.rules.model.ConditionType condType = c.conditionType() == ConditionType.ROLLOUT
-                ? io.split.rules.model.ConditionType.ROLLOUT
-                : io.split.rules.model.ConditionType.WHITELIST;
-        return new io.split.rules.model.Condition(condType, c.matcher(), partitions, c.label());
-    }
-
     public Set<String> getSegmentsNames() {
         return parsedConditions().stream()
                 .flatMap(parsedCondition -> parsedCondition.matcher().attributeMatchers().stream())
diff --git a/client/src/main/java/io/split/engine/experiments/TargetingRuleFactory.java b/client/src/main/java/io/split/engine/experiments/TargetingRuleFactory.java
@@ -0,0 +1,59 @@
+package io.split.engine.experiments;
+
+import io.split.rules.matchers.PrerequisitesMatcher;
+import io.split.rules.model.Condition;
+import io.split.rules.model.ConditionType;
+import io.split.rules.model.Partition;
+import io.split.rules.model.Prerequisite;
+import io.split.rules.model.TargetingRule;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public final class TargetingRuleFactory {
+
+    private TargetingRuleFactory() {
+        throw new IllegalStateException("Utility class");
+    }
+
+    public static TargetingRule buildTargetingRule(
+            String feature, int seed, boolean killed, String defaultTreatment,
+            List<ParsedCondition> matcherAndSplits, String trafficTypeName, long changeNumber,
+            int trafficAllocation, int trafficAllocationSeed, int algo,
+            Map<String, String> configurations, HashSet<String> flagSets,
+            boolean impressionsDisabled, PrerequisitesMatcher prerequisitesMatcher) {
+
+        List<Condition> conditions = matcherAndSplits == null
+                ? Collections.emptyList()
+                : matcherAndSplits.stream()
+                        .map(TargetingRuleFactory::toTargetingCondition)
+                        .collect(Collectors.toList());
+
+        List<Prerequisite> prereqs = prerequisitesMatcher == null
+                ? Collections.emptyList()
+                : prerequisitesMatcher.getPrerequisites() == null
+                        ? Collections.emptyList()
+                        : Collections.unmodifiableList(prerequisitesMatcher.getPrerequisites());
+
+        return new TargetingRule(feature, seed, killed, defaultTreatment, conditions, trafficTypeName,
+                changeNumber, trafficAllocation, trafficAllocationSeed, algo, configurations,
+                flagSets == null ? new HashSet<>() : flagSets, impressionsDisabled, prereqs);
+    }
+
+    private static Condition toTargetingCondition(ParsedCondition c) {
+        List<Partition> partitions = c.partitions() == null
+                ? Collections.emptyList()
+                : c.partitions().stream()
+                        .map(p -> new Partition(p.treatment, p.size))
+                        .collect(Collectors.toList());
+
+        ConditionType condType = c.conditionType() == io.split.client.dtos.ConditionType.ROLLOUT
+                ? ConditionType.ROLLOUT
+                : ConditionType.WHITELIST;
+
+        return new Condition(condType, c.matcher(), partitions, c.label());
+    }
+}
diff --git a/client/src/test/java/io/split/engine/experiments/TargetingRuleFactoryTest.java b/client/src/test/java/io/split/engine/experiments/TargetingRuleFactoryTest.java
