fix issue with --arg value and --arg=value (#2999)

Adel-Moumen · Copilot · web-flow · commit c3b5fceaa00b · 2025-11-24T10:06:01.000-05:00
Co-authored-by: Copilot &lt;198982749+Copilot@users.noreply.github.com&gt;
diff --git a/speechbrain/utils/run_opts.py b/speechbrain/utils/run_opts.py
@@ -266,10 +266,16 @@ def from_command_line_args(cls, arg_list=None):
 
         # Go through arg list to see which were set
         # NOTE: Slight risk of collisions if an arg value matches an arg name
-        overridden_args = {
-            arg_mapping[arg] for arg in arg_list if arg in arg_mapping
-        }
-
+        overridden_args = set()
+        for arg in arg_list:
+            # Handle both --arg=value and --arg value formats
+            if arg.startswith("--") and "=" in arg:
+                # Split on first = to get the argument name
+                arg_name = arg.split("=", 1)[0]
+                if arg_name in arg_mapping:
+                    overridden_args.add(arg_mapping[arg_name])
+            elif arg in arg_mapping:
+                overridden_args.add(arg_mapping[arg])
         # Add a record of which args were specified
         run_opts = cls(
             **{**vars(parsed_args), "overridden_args": overridden_args}
diff --git a/tests/unittests/test_core.py b/tests/unittests/test_core.py
@@ -9,6 +9,49 @@ def test_parse_arguments():
     assert overrides == "seed: 3\ndata_folder: TIMIT"
 
 
+def test_parse_arguments_both_formats():
+    """Test that both --arg=value and --arg value formats work correctly."""
+    from speechbrain.utils.run_opts import RunOptions
+
+    # Test with --arg=value format
+    filename1, run_opts1, overrides1 = RunOptions.from_command_line_args(
+        ["params.yaml", "--device=cuda:0", "--seed=42"]
+    )
+    assert filename1 == "params.yaml"
+    assert run_opts1["device"] == "cuda:0"
+    assert "device" in run_opts1.overridden_args
+
+    # Test with --arg value format
+    filename2, run_opts2, overrides2 = RunOptions.from_command_line_args(
+        [
+            "params.yaml",
+            "--device",
+            "cuda:1",
+            "--max_grad_norm",
+            "10.0",
+            "--seed",
+            "99",
+        ]
+    )
+    assert filename2 == "params.yaml"
+    assert run_opts2["device"] == "cuda:1"
+    assert run_opts2["max_grad_norm"] == 10.0
+    assert "device" in run_opts2.overridden_args
+    assert "max_grad_norm" in run_opts2.overridden_args
+    assert overrides2 == "seed: 99"
+
+    # Test with mixed formats
+    filename3, run_opts3, overrides3 = RunOptions.from_command_line_args(
+        ["params.yaml", "--device=cuda:2", "--max_grad_norm", "5.0", "--seed=7"]
+    )
+    assert filename3 == "params.yaml"
+    assert run_opts3["device"] == "cuda:2"
+    assert run_opts3["max_grad_norm"] == 5.0
+    assert "device" in run_opts3.overridden_args
+    assert "max_grad_norm" in run_opts3.overridden_args
+    assert overrides3 == "seed: 7"
+
+
 def test_brain(device):
     import torch
     from torch.optim import SGD
