Add test for various length mask functions (code from Samsung, AI Center, Cambridge) (#2894)

rogiervd · Rogier van Dalen · Adel-Moumen · web-flow · commit ba9364af76f9 · 2025-05-20T16:12:36.000-04:00
Co-authored-by: Rogier van Dalen &lt;r.vandalen@samsung.com&gt;
Co-authored-by: Adel Moumen &lt;88119391+Adel-Moumen@users.noreply.github.com&gt;
diff --git a/speechbrain/nnet/losses.py b/speechbrain/nnet/losses.py
@@ -917,7 +917,7 @@ def compute_length_mask(data, length=None, len_dim=1):
     mask = torch.ones_like(data)
     if length is not None:
         length_mask = length_to_mask(
-            length * data.shape[len_dim],
+            (length * data.shape[len_dim] - 1e-6),
             max_len=data.shape[len_dim],
         )
 
diff --git a/speechbrain/processing/features.py b/speechbrain/processing/features.py
@@ -1545,7 +1545,7 @@ def _load(self, path, end_of_epoch=False):
         self._load_statistics_dict(stats)
 
 
-def make_padding_mask(x, lengths=None, length_dim=1, eps=1e-8):
+def make_padding_mask(x, lengths=None, length_dim=1, eps=1e-6):
     """Create a mask from relative lengths along a given dimension.
 
     Arguments
@@ -1597,7 +1597,7 @@ def make_padding_mask(x, lengths=None, length_dim=1, eps=1e-8):
 
     # Convert relative lengths to absolute lengths, then compute boolean mask
     max_len = x.size(length_dim)
-    abs_lengths = (lengths * max_len + eps).unsqueeze(1)
+    abs_lengths = (lengths * max_len - eps).unsqueeze(1)
     mask = torch.arange(max_len, device=x.device).unsqueeze(0) < abs_lengths
 
     # Add dimensions other than (batch, length) back into the mask
diff --git a/tests/unittests/test_length_mask.py b/tests/unittests/test_length_mask.py

Original file line number	Diff line number	Diff line change
`@@ -917,7 +917,7 @@ def compute_length_mask(data, length=None, len_dim=1):`
`917`	`917`	`mask = torch.ones_like(data)`
`918`	`918`	`if length is not None:`
`919`	`919`	`length_mask = length_to_mask(`
`920`		`- length * data.shape[len_dim],`
	`920`	`+ (length * data.shape[len_dim] - 1e-6),`
`921`	`921`	`max_len=data.shape[len_dim],`
`922`	`922`	`)`
`923`	`923`