Skip to content

Commit 9a4deaa

Browse files
authored
Merge pull request #1903 from pplantinga/bugfix/train-logger-warning
Fix unnecessary warning in train logger
2 parents 5a746f9 + 6386afb commit 9a4deaa

5 files changed

Lines changed: 18 additions & 14 deletions

File tree

‎speechbrain/core.py‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ def __init__( # noqa: C901
512512
sys.version_info.major == PYTHON_VERSION_MAJOR
513513
and sys.version_info.minor >= PYTHON_VERSION_MINOR
514514
):
515-
logger.warn(
515+
logger.warning(
516516
"Detected Python "
517517
+ str(sys.version_info.major)
518518
+ "."
@@ -598,7 +598,7 @@ def __init__( # noqa: C901
598598
"--distributed_launch=True --distributed_backend=nccl"
599599
)
600600
else:
601-
logger.warn(
601+
logger.warning(
602602
"To use DDP, please add "
603603
"sb.utils.distributed.ddp_init_group() into your exp.py"
604604
)
@@ -996,10 +996,10 @@ def check_gradients(self, loss):
996996
self.nonfinite_count += 1
997997

998998
# Print helpful debug info
999-
logger.warn(f"Loss is {loss}.")
999+
logger.warning(f"Loss is {loss}.")
10001000
for p in self.modules.parameters():
10011001
if not torch.isfinite(p).all():
1002-
logger.warn("Parameter is not finite: " + str(p))
1002+
logger.warning("Parameter is not finite: " + str(p))
10031003

10041004
# Check if patience is exhausted
10051005
if self.nonfinite_count > self.nonfinite_patience:
@@ -1010,7 +1010,9 @@ def check_gradients(self, loss):
10101010
"torch.autograd.detect_anomaly():\n\tbrain.fit(...)"
10111011
)
10121012
else:
1013-
logger.warn("Patience not yet exhausted, ignoring this batch.")
1013+
logger.warning(
1014+
"Patience not yet exhausted, ignoring this batch."
1015+
)
10141016
return False
10151017

10161018
# Clip gradient norm

‎speechbrain/tokenizers/SentencePiece.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,13 +370,13 @@ def _check_coverage_from_bpe(self, list_annotation_files=[]):
370370
fannotation_file.close()
371371
logger.info("recover words from: " + annotation_file)
372372
if len(wrong_recover_list) > 0:
373-
logger.warn(
373+
logger.warning(
374374
"Wrong recover words: " + str(len(wrong_recover_list))
375375
)
376-
logger.warn(
376+
logger.warning(
377377
"Tokenizer vocab size: " + str(self.sp.vocab_size())
378378
)
379-
logger.warn(
379+
logger.warning(
380380
"accuracy recovering words: "
381381
+ str(
382382
1

‎speechbrain/utils/hpopt.py‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def hpopt_mode(mode):
6868
"""
6969

7070
def f(cls):
71-
""""Call the function that registers and returns the reporter class"""
71+
""" "Call the function that registers and returns the reporter class"""
7272
_hpopt_modes[mode] = cls
7373
return cls
7474

@@ -269,11 +269,13 @@ def get_reporter(mode, *args, **kwargs):
269269
"""
270270
reporter_cls = _hpopt_modes.get(mode)
271271
if reporter_cls is None:
272-
logger.warn(f"hpopt_mode {mode} is not supported, reverting to generic")
272+
logger.warning(
273+
f"hpopt_mode {mode} is not supported, reverting to generic"
274+
)
273275
reporter_cls = _hpopt_modes[DEFAULT_REPORTER]
274276
reporter = reporter_cls(*args, **kwargs)
275277
if not reporter.is_available:
276-
logger.warn("Reverting to a generic reporter")
278+
logger.warning("Reverting to a generic reporter")
277279
reporter_cls = _hpopt_modes[DEFAULT_REPORTER]
278280
reporter = reporter_cls(*args, **kwargs)
279281
return reporter

‎speechbrain/utils/torch_audio_backend.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def check_torchaudio_backend():
1616
"""
1717
current_system = platform.system()
1818
if current_system == "Windows":
19-
logger.warn(
19+
logger.warning(
2020
"The torchaudio backend is switched to 'soundfile'. Note that 'sox_io' is not supported on Windows."
2121
)
2222
torchaudio.set_audio_backend("soundfile")

‎speechbrain/utils/train_logger.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def _get_image_saver():
224224

225225
return torchvision.utils.save_image
226226
except ImportError:
227-
logger.warn("torchvision is not available - cannot save figures")
227+
logger.warning("torchvision is not available - cannot save figures")
228228
return None
229229

230230

@@ -404,7 +404,7 @@ def plot_spectrogram(spectrogram, ap=None, fig_size=(16, 10), output_fig=False):
404404
import matplotlib.pyplot as plt
405405

406406
except ImportError:
407-
logger.warn("matplotlib is not available - cannot log figures")
407+
logger.warning("matplotlib is not available - cannot log figures")
408408
return None
409409

410410
spectrogram = spectrogram.detach().cpu().numpy().squeeze()

0 commit comments

Comments
 (0)