perf(ivy): avoid creating bound function in pipeBind3 (angular#23882)

JoostK · alxhub · commit 83631b28cb76 · 2018-05-15T11:40:33.000-07:00
PR Close angular#23882
diff --git a/packages/core/src/render3/pipe.ts b/packages/core/src/render3/pipe.ts
@@ -102,7 +102,7 @@ export function pipeBind2(index: number, v1: any, v2: any): any {
  */
 export function pipeBind3(index: number, v1: any, v2: any, v3: any): any {
   const pipeInstance = load<PipeTransform>(index);
-  return isPure(index) ? pureFunction3(pipeInstance.transform.bind(pipeInstance), v1, v2, v3) :
+  return isPure(index) ? pureFunction3(pipeInstance.transform, v1, v2, v3, pipeInstance) :
                          pipeInstance.transform(v1, v2, v3);
 }
 
diff --git a/packages/core/src/render3/pure_function.ts b/packages/core/src/render3/pure_function.ts
@@ -15,6 +15,7 @@ import {bindingUpdated, bindingUpdated2, bindingUpdated4, checkAndUpdateBinding,
  * value. If it has been saved, returns the saved value.
  *
  * @param pureFn Function that returns a value
+ * @param thisArg Optional calling context of pureFn
  * @returns value
  */
 export function pureFunction0<T>(pureFn: () => T, thisArg?: any): T {
@@ -28,6 +29,7 @@ export function pureFunction0<T>(pureFn: () => T, thisArg?: any): T {
  *
  * @param pureFn Function that returns an updated value
  * @param exp Updated expression value
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction1(pureFn: (v: any) => any, exp: any, thisArg?: any): any {
@@ -43,6 +45,7 @@ export function pureFunction1(pureFn: (v: any) => any, exp: any, thisArg?: any):
  * @param pureFn
  * @param exp1
  * @param exp2
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction2(
@@ -60,6 +63,7 @@ export function pureFunction2(
  * @param exp1
  * @param exp2
  * @param exp3
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction3(
@@ -81,6 +85,7 @@ export function pureFunction3(
  * @param exp2
  * @param exp3
  * @param exp4
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction4(
@@ -102,6 +107,7 @@ export function pureFunction4(
  * @param exp3
  * @param exp4
  * @param exp5
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction5(
@@ -126,6 +132,7 @@ export function pureFunction5(
  * @param exp4
  * @param exp5
  * @param exp6
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction6(
@@ -151,6 +158,7 @@ export function pureFunction6(
  * @param exp5
  * @param exp6
  * @param exp7
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction7(
@@ -178,6 +186,7 @@ export function pureFunction7(
  * @param exp6
  * @param exp7
  * @param exp8
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunction8(
@@ -200,7 +209,8 @@ export function pureFunction8(
  *
  * @param pureFn A pure function that takes binding values and builds an object or array
  * containing those values.
- * @param exp An array of binding values
+ * @param exps An array of binding values
+ * @param thisArg Optional calling context of pureFn
  * @returns Updated value
  */
 export function pureFunctionV(pureFn: (...v: any[]) => any, exps: any[], thisArg?: any): any {

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ export function pipeBind2(index: number, v1: any, v2: any): any {`
`102`	`102`	`*/`
`103`	`103`	`export function pipeBind3(index: number, v1: any, v2: any, v3: any): any {`
`104`	`104`	`const pipeInstance = load<PipeTransform>(index);`
`105`		`- return isPure(index) ? pureFunction3(pipeInstance.transform.bind(pipeInstance), v1, v2, v3) :`
	`105`	`+ return isPure(index) ? pureFunction3(pipeInstance.transform, v1, v2, v3, pipeInstance) :`
`106`	`106`	`pipeInstance.transform(v1, v2, v3);`
`107`	`107`	`}`
`108`	`108`