py/objbool: Simplify dispatch of bool binary op.

dpgeorge · dpgeorge · commit 0b7a66ab9795 · 2015-09-04T16:46:15.000+01:00
This optimises (in speed and code size) for the common case where the
binary op for the bool object is supported.  Unsupported binary ops
still behave the same.
diff --git a/py/objbool.c b/py/objbool.c
@@ -88,10 +88,8 @@ STATIC mp_obj_t bool_unary_op(mp_uint_t op, mp_obj_t o_in) {
 }
 
 STATIC mp_obj_t bool_binary_op(mp_uint_t op, mp_obj_t lhs_in, mp_obj_t rhs_in) {
-    if (MP_BINARY_OP_OR <= op && op <= MP_BINARY_OP_NOT_EQUAL) {
-        return mp_binary_op(op, MP_OBJ_NEW_SMALL_INT(mp_obj_is_true(lhs_in)), rhs_in);
-    }
-    return MP_OBJ_NULL; // op not supported
+    mp_obj_bool_t *self = lhs_in;
+    return mp_binary_op(op, MP_OBJ_NEW_SMALL_INT(self->value), rhs_in);
 }
 
 const mp_obj_type_t mp_type_bool = {

Original file line number	Diff line number	Diff line change
`@@ -88,10 +88,8 @@ STATIC mp_obj_t bool_unary_op(mp_uint_t op, mp_obj_t o_in) {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`STATIC mp_obj_t bool_binary_op(mp_uint_t op, mp_obj_t lhs_in, mp_obj_t rhs_in) {`
`91`		`- if (MP_BINARY_OP_OR <= op && op <= MP_BINARY_OP_NOT_EQUAL) {`
`92`		`- return mp_binary_op(op, MP_OBJ_NEW_SMALL_INT(mp_obj_is_true(lhs_in)), rhs_in);`
`93`		`- }`
`94`		`- return MP_OBJ_NULL; // op not supported`
	`91`	`+ mp_obj_bool_t *self = lhs_in;`
	`92`	`+ return mp_binary_op(op, MP_OBJ_NEW_SMALL_INT(self->value), rhs_in);`
`95`	`93`	`}`
`96`	`94`
`97`	`95`	`const mp_obj_type_t mp_type_bool = {`