Add a separate buildkite step checking code formatting and licenses (temporalio#253)

Spikhalskiy · web-flow · commit 2b253c81c07d · 2022-03-17T15:34:11.000-04:00
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -9,7 +9,18 @@ steps:
       - docker-compose#v3.0.0:
           run: unit-test
           config: docker/buildkite/docker-compose.yaml
-          
+
+  - label: ":copyright: Copyright and code format"
+    agents:
+      queue: "default"
+      docker: "*"
+    command: "docker/buildkite/copyright-and-code-format.sh"
+    timeout_in_minutes: 15
+    plugins:
+      - docker-compose#v3.8.0:
+          run: unit-test
+          config: docker/buildkite/docker-compose.yaml
+
   - label: ":alien: Fossa scan"
     agents:
       queue: "default"
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,3 @@
+# Primary owners
+
+* @tsurdilo @Spikhalskiy
diff --git a/docker/buildkite/Dockerfile b/docker/buildkite/Dockerfile
@@ -1,16 +1,7 @@
-FROM openjdk:8-alpine
-
-# Based on https://github.com/sgerrand/alpine-pkg-glibc
-# Needed to run protoc java plugin
-RUN wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub
-RUN wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.31-r0/glibc-2.31-r0.apk
-RUN apk add glibc-2.31-r0.apk
-
-# Install dependencies using apk
-RUN apk update && apk add --virtual wget ca-certificates wget && apk add protobuf
+FROM openjdk:8-slim
 
 # Git is needed in order to update the dls submodule
-RUN apk add --virtual git
+RUN apt-get update && apt-get install -y wget protobuf-compiler git
 
 # Fossa to run license scans
 RUN wget -O- https://raw.githubusercontent.com/fossas/fossa-cli/master/install.sh | sh
diff --git a/docker/buildkite/copyright-and-code-format.sh b/docker/buildkite/copyright-and-code-format.sh
@@ -0,0 +1,11 @@
+#!/bin/bash
+set -xeou pipefail
+
+./gradlew --no-daemon check -x test
+
+if [ ! -z "$(git status --porcelain)" ]; then 
+	echo 'Some files were improperly formatted. Please run build locally and check in all changes.'
+	git status;
+	exit 1;
+fi
+
diff --git a/src/main/java/io/temporal/samples/payloadconverter/crypto/MyCustomer.java b/src/main/java/io/temporal/samples/payloadconverter/crypto/MyCustomer.java
@@ -1,3 +1,22 @@
+/*
+ *  Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
+ *
+ *  Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ *  Modifications copyright (C) 2017 Uber Technologies, Inc.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License"). You may not
+ *  use this file except in compliance with the License. A copy of the License is
+ *  located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ *  or in the "license" file accompanying this file. This file is distributed on
+ *  an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ *  express or implied. See the License for the specific language governing
+ *  permissions and limitations under the License.
+ */
+
 package io.temporal.samples.payloadconverter.crypto;
 
 import com.codingrodent.jackson.crypto.Encrypt;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# Primary owners`
	`2`	`+`
	`3`	`+* @tsurdilo @Spikhalskiy`