Skip to content

Commit fa99b0f

Browse files
committed
change category to categories and other housekeeping notes
1 parent 2744323 commit fa99b0f

File tree

3 files changed

+26
-10
lines changed

3 files changed

+26
-10
lines changed

app/src/processing/app/contrib/Contribution.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131

3232
abstract public class Contribution {
3333
static final String IMPORTS_PROPERTY = "imports";
34-
static final String CATEGORIES_PROPERTY = "category";
34+
// static final String CATEGORIES_PROPERTY = "category";
35+
static final String CATEGORIES_PROPERTY = "categories";
3536
//static final String MODES_PROPERTY = "compatibleModesList";
3637
static final String MODES_PROPERTY = "modes";
3738
//static final String AUTHORS_PROPERTY = "authorList";
@@ -252,6 +253,9 @@ static StringList parseCategories(StringDict properties) {
252253
StringList outgoing = new StringList();
253254

254255
String categoryStr = properties.get(CATEGORIES_PROPERTY);
256+
if (categoryStr == null) {
257+
categoryStr = properties.get("category"); // try the old way
258+
}
255259
if (categoryStr != null) {
256260
String[] listing = PApplet.trim(PApplet.split(categoryStr, ','));
257261
for (String category : listing) {

java/src/processing/mode/java/preproc/PdePreprocessor.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,10 +288,12 @@ make sure that it uses numbers (or displayWidth/Height), copy into settings
288288
char[] c = searchArea.toCharArray();
289289
int depth = 0;
290290
int closeBrace = -1;
291+
// boolean literal; // inside a quoted literal?
291292
StringBuilder sb = new StringBuilder();
292293
for (int i = openBrace; i < c.length; i++) {
293294
if (c[i] == '{') {
294295
depth++;
296+
// } else if (c[i] == '\'') {
295297
} else if (c[i] == '}') {
296298
depth--;
297299
if (depth == 0) {

todo.txt

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@ X https://github.com/processing/processing/issues/3383
99
X Show "not compatible" error message in the manager
1010
X https://github.com/processing/processing/issues/3386
1111
X Add more code for handling low-level errors on startup
12+
X update the "Supported Platforms" wiki page with current status
1213

1314
manager
1415
X changed compatibleModesList to modes in examples.properties
1516
X changed authorList to authors to keep in line w/ the others
16-
`authorList` has now changed to `authors` (though `authorList` still works to keep compatibility) Oddly enough, authorList was not a list (it's free-form text that might be a list), yet others that were lists didn't have 'list' in the name
17-
_ need to make a note of these
18-
_ should we change category to categories?
17+
X changed category to categories
1918
X send list of installed Libraries, Modes, Tools, and Examples on update
2019
X https://github.com/processing/processing/issues/3365
20+
X disable contrib manager updates when "check for updates" is turned off
21+
X update the FAQ to cover the changes
2122

2223
contribs
2324
X Use correct localized strings in JavaEditor.java
@@ -26,6 +27,10 @@ X dim edit menus as appropriate during selection/no selection/etc
2627
o http://code.google.com/p/processing/issues/detail?id=14
2728
X https://github.com/processing/processing/issues/53
2829
X https://github.com/processing/processing/pull/3419
30+
X Internationalize MovieMaker.java
31+
X https://github.com/processing/processing/pull/3424
32+
X Auto-completion does not seem to be working
33+
X https://github.com/processing/processing/issues/3111
2934

3035
gsoc
3136
X Mode problems window wasn't doing line breaks
@@ -36,15 +41,19 @@ X https://github.com/processing/processing/pull/3392
3641
X Examples window shows contributed examples
3742
X https://github.com/processing/processing/pull/3421
3843
X https://github.com/processing/processing/pull/3421
44+
X reworking the Contribution Manager according to Scott's redesign
45+
X https://github.com/processing/processing/pull/3423
46+
X finish adding 'examples' contribs
47+
X https://github.com/processing/processing/issues/2953
48+
o don't return here, allow contrib types to fail:
49+
o https://github.com/processing/processing/blob/master/app/src/processing/app/contrib/ContributionListing.java#L509
3950

4051
cleaning
4152
o libraries in java tabs (separate .java files) are reported missing
4253
o need to scan the .java files for imports that need to be included
4354
o http://code.google.com/p/processing/issues/detail?id=459
4455
X https://github.com/processing/processing/issues/498
4556

46-
"OS X v10.11 is the last major release of OS X that will support the previously deprecated Java 6 runtime and tools provided by Apple. Applications or features that depend upon Java 6 may not function properly or will not launch when Java 6 is removed." https://developer.apple.com/library/prerelease/mac/releasenotes/General/rn-osx-10.11/index.html
47-
4857

4958
beta
5059
_ add "welcome" or "what's new" window to explain features in 3
@@ -100,7 +109,12 @@ _ recent menu gets huge with other p5 versions on osx
100109

101110
pde/build
102111
_ error message caused by curly bracket in a println string
112+
_ ((?<![\\])['"])((?:.(?!(?<![\\])\1))*.?)\1 to match quoted strings
103113
_ https://github.com/processing/processing/issues/3394
114+
_ dim out the Run button if there are compile errors detected
115+
_ the AST checker has better error message handling for those cases
116+
_ and hitting Run replaces the useful error with something weird
117+
_ https://github.com/processing/processing/issues/3408
104118
_ when variables used in size(), getting exceptions instead of any warning
105119
_ https://github.com/processing/processing/issues/3311
106120
_ crashed on startup w/ JavaScript mode as default b/c PdeKeyListener not found
@@ -118,10 +132,6 @@ _ make a Tool that installs it for all platforms, not just OS X
118132
_ not really part of the 'build' anymore
119133
_ break out Mode options to their own panels in prefs
120134
_ Mode should just provide a panel for their prefs
121-
_ finish adding 'examples' contribs
122-
_ https://github.com/processing/processing/issues/2953
123-
_ don't return here, allow contrib types to fail:
124-
_ https://github.com/processing/processing/blob/master/app/src/processing/app/contrib/ContributionListing.java#L509
125135
_ add build.xml prompt for OS X developers to download the JDK update
126136
_ make examples pull/build automatic during dist
127137
_ dist needs to do a git pull on processing-docs

0 commit comments

Comments
 (0)