Rewrite scip-java CLI to Kotlin#907
Draft
jupblb wants to merge 6 commits into
Draft
Conversation
f5dd87b to
79285d1
Compare
Keep only the members called from outside Kotlin: the JVM main entry point and the ones invoked by the Scala test suites. The docs mdoc snippet now calls printHelp via the object instance.
Replace the Kotlin-only AbsolutePath wrapper with java.nio.file stdlib resolve/toAbsolutePath calls. The working directory is always absolute, so the relative-cwd fallback branch was dead and is removed.
Kotlin call sites use File.deleteRecursively from the stdlib; Scala tests use the already-present os-lib os.remove.all. The one selective-delete use (SaveSnapshotHandler) inlines a SimpleFileVisitor, which is its only caller.
- ScipSymbol: collapse the unused sealed hierarchy (parsed data was never read) into a validation function - ClasspathEntry: remove the unread 'sources' field - ScipBuildTool: drop dead Config.bootclasspath/jvm, the unused error-message list (use a boolean), a redundant mkdir, and an always-true classpath guard - ScipJavaApp: remove the dead out/err stream aliases - IndexCommand: remove the unused withApp - CliEnvironment: remove the unused withEnvironmentVariables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the
scip-javaCLI module from Scala to Kotlin (clikt + kotlinx-serialization), dropping the moped runtime. Tests migrated to a local harness; moped-testkit replaced by an explicit os-lib dependency.