Skip to content

[bug] Minor url encoding issue with parentheses #668

Closed

Description

@gooverdian

Describe the bug

Parentheses are left unencoded in the url. While it's okay for the browser itself, MD files or Slack or Mattermost etc are seeing those as a url separator, so you end up either copying it manually, or just encoding those by hand before sending it.

To reproduce

Just search something with parenthesis, and then try to make an md url:

[not-a-rick-roll](https://sourcebot.host.com/~/search?query="sentry.%7B1%2C20%7D%5C.set_user%5C(.%7B1%2C80%7Duser_id"&isRegexEnabled=true)

becomes broken

[not-a-rick-roll](https://sourcebot.host.com/~/search?query="sentry.%7B1%2C20%7D%5C.set_user%5C(.%7B1%2C80%7Duser_id"&isRegexEnabled=true)

while it could be

not-a-rick-roll

Just to be sure, I've checked if hand-encoded url ( ( => %28 ) works, it was ok for sourcebot to interpret it.

Sourcebot deployment information

self-hosted, latest

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions