Tools: Fuzzer: Do not use illegal BUILD_COMMAND in CMakeLists.txt

singalsu · lgirdwood · commit f430addec752 · 2020-08-31T11:30:26.000+01:00
This patch removes the incorrect usage of BUILD_COMMAND. Having it set to "cmake" caused the cmake usage help text output to be shown only and caused the ExternalProject_Add command to believe the libsof_tplg_parser.so was built. The build for the library happened only because the next install step performed the compilation. With this fix the default build command is used instead. There's no need to define it here. Fixes thesofproject#2656 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Marc Herbert <marc.herbert@intel.com>
diff --git a/tools/fuzzer/CMakeLists.txt b/tools/fuzzer/CMakeLists.txt
@@ -23,7 +23,6 @@ ExternalProject_Add(sof_parser_ep
 	BINARY_DIR "${PROJECT_BINARY_DIR}/sof_parser/build"
 	CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${parser_install_dir}
 		-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}
-	BUILD_COMMAND ${CMAKE_COMMAND}
 	BUILD_ALWAYS 1
 	BUILD_BYPRODUCTS "${parser_install_dir}/lib/libsof_tplg_parser.so"
 )

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ ExternalProject_Add(sof_parser_ep`
`23`	`23`	`BINARY_DIR "${PROJECT_BINARY_DIR}/sof_parser/build"`
`24`	`24`	`CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${parser_install_dir}`
`25`	`25`	`-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}`
`26`		`- BUILD_COMMAND ${CMAKE_COMMAND}`
`27`	`26`	`BUILD_ALWAYS 1`
`28`	`27`	`BUILD_BYPRODUCTS "${parser_install_dir}/lib/libsof_tplg_parser.so"`
`29`	`28`	`)`