Firebase: print params (GoogleCloudPlatform#1368)

Ace Nassri · web-flow · commit e4e707ecc985 · 2019-06-14T12:12:12.000-07:00
* Use mocha + add params console.log statement

* Update index.js
diff --git a/functions/firebase/index.js b/functions/firebase/index.js
@@ -22,6 +22,14 @@
 exports.helloRTDB = event => {
   const triggerResource = event.resource;
 
+  const pathParams = event.params;
+  if (pathParams) {
+    console.log(`Path parameters:`);
+    Object.keys(pathParams).forEach(key => {
+      console.log(`  ${key}: ${pathParams[key]}`);
+    });
+  }
+
   console.log(`Function triggered by change to: ${triggerResource}`);
   console.log(`Admin?: ${!!event.auth.admin}`);
   console.log(`Delta:`);
diff --git a/functions/firebase/package.json b/functions/firebase/package.json
@@ -12,11 +12,11 @@
     "node": ">=8.0.0"
   },
   "scripts": {
-    "test": "ava -T 30s test/*.test.js"
+    "test": "mocha -T 30s test/*.test.js"
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.3.0",
-    "ava": "^2.0.0",
+    "mocha": "^6.1.4",
     "proxyquire": "^2.1.0",
     "sinon": "^7.2.7",
     "supertest": "^4.0.0",
diff --git a/functions/firebase/test/index.test.js b/functions/firebase/test/index.test.js
@@ -51,10 +51,14 @@ it('should listen to RTDB', () => {
       admin: true,
     },
     delta: delta,
+    params: {
+      baz: 'quux',
+    },
   };
 
   sample.program.helloRTDB(event);
 
+  assert.strictEqual(console.log.calledWith('  baz: quux'), true);
   assert.strictEqual(
     console.log.calledWith('Function triggered by change to: resource'),
     true
diff --git a/functions/node8/index.js b/functions/node8/index.js
@@ -161,6 +161,14 @@ exports.helloGCSGeneric = (data, context) => {
 exports.helloRTDB = (data, context) => {
   const triggerResource = context.resource;
 
+  const pathParams = data.params;
+  if (pathParams) {
+    console.log(`Parameters:`);
+    Object.entries(pathParams).forEach(([param, value]) => {
+      console.log(`  ${param}: ${value}`);
+    });
+  }
+
   console.log(`Function triggered by change to: ${triggerResource}`);
   console.log(`Admin?: ${!!data.admin}`);
   console.log(`Delta:`);
diff --git a/functions/node8/test/index.test.js b/functions/node8/test/index.test.js
@@ -110,16 +110,20 @@ it('should monitor Firebase RTDB', () => {
     delta: {
       id: dataId,
     },
+    params: {
+      baz: 'quux',
+    },
   };
   const context = {
     resource: resourceId,
   };
 
   sample.program.helloRTDB(data, context);
 
-  assert.strictEqual(console.log.firstCall.args[0].includes(resourceId), true);
-  assert.deepStrictEqual(console.log.secondCall.args, ['Admin?: true']);
-  assert.strictEqual(console.log.getCall(3).args[0].includes(dataId), true);
+  assert.deepStrictEqual(console.log.getCall(1).args, ['  baz: quux']);
+  assert.strictEqual(console.log.getCall(2).args[0].includes(resourceId), true);
+  assert.deepStrictEqual(console.log.getCall(3).args, ['Admin?: true']);
+  assert.strictEqual(console.log.getCall(5).args[0].includes(dataId), true);
 });
 
 it('should monitor Firestore', () => {
