Remove semistandard from appengine configs (GoogleCloudPlatform#902)

fhinkel · web-flow · commit 44f689d18781 · 2018-11-14T17:39:21.000-05:00
Remove semistandard from appengine configs. Use eslint and prettier.
diff --git a/.eslintignore b/.eslintignore
@@ -2,4 +2,4 @@
 appengine/loopback/*
 functions/**
 iot/*
-appengine/*
+appengine/parse-server/cloud/main.js
diff --git a/README.md b/README.md
@@ -131,14 +131,10 @@ on Google Cloud Platform.
 
     Read more about [Google Cloud Platform Authentication][gcp_auth].
 
-    __Note for running unit tests:__
-
-    Install [semistandard][] (lint tool)
 
 [node]: https://nodejs.org/
 [auth_command]: https://cloud.google.com/sdk/gcloud/reference/beta/auth/application-default/login
 [gcp_auth]: https://cloud.google.com/docs/authentication#projects_and_resources
-[semistandard]: https://www.npmjs.com/package/semistandard
 
 ### How to run a sample
 
diff --git a/appengine/analytics/package.json b/appengine/analytics/package.json
@@ -14,8 +14,6 @@
   },
   "scripts": {
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app",
     "test": "npm run system-test"
   },
@@ -24,8 +22,7 @@
     "got": "8.3.2"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^3.0.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/building-an-app/build/package.json b/appengine/building-an-app/build/package.json
@@ -7,8 +7,6 @@
   "scripts": {
     "start": "node server.js",
     "deploy": "gcloud app deploy",
-    "lint": "samples lint",
-    "pretest": "npm run lint",
     "test": "samples test app"
   },
   "repository": {
@@ -25,8 +23,7 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "1.4.17",
-    "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "ava": "0.25.0"
   },
   "cloud-repo-tools": {
     "requiresKeyFile": false,
diff --git a/appengine/building-an-app/update/package.json b/appengine/building-an-app/update/package.json
@@ -7,8 +7,6 @@
   "scripts": {
     "start": "node server.js",
     "deploy": "gcloud app deploy",
-    "lint": "samples lint",
-    "pretest": "npm run lint",
     "test": "ava --verbose test/*.test.js"
   },
   "repository": {
@@ -22,12 +20,10 @@
   "license": "Apache-2.0",
   "dependencies": {
     "body-parser": "^1.18.2",
-    "express": "^4.16.3",
-    "semistandard": "^12.0.1"
+    "express": "^4.16.3"
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "1.4.17",
-    "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "ava": "0.25.0"
   }
 }
diff --git a/appengine/cloudsql/package.json b/appengine/cloudsql/package.json
@@ -13,8 +13,6 @@
     "node": ">=8"
   },
   "scripts": {
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "unit-test": "ava --verbose test/*.test.js",
     "start-proxy": "! pgrep cloud_sql_proxy > /dev/null && cloud_sql_proxy -instances=$INSTANCE_CONNECTION_NAME=tcp:$SQL_PORT &",
     "system-test": "repo-tools test app -- server.js",
@@ -32,7 +30,9 @@
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
     "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "requiresKeyFile": true,
diff --git a/appengine/cloudsql_postgresql/package.json b/appengine/cloudsql_postgresql/package.json
@@ -13,8 +13,6 @@
     "node": ">=8"
   },
   "scripts": {
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "unit-test": "ava --verbose test/*.test.js",
     "start-proxy": "! pgrep cloud_sql_proxy > /dev/null && cloud_sql_proxy -instances=$INSTANCE_CONNECTION_NAME=tcp:$SQL_PORT &",
     "system-test": "repo-tools test app -- server.js",
@@ -32,7 +30,9 @@
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
     "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "requiresKeyFile": true,
diff --git a/appengine/datastore/package.json b/appengine/datastore/package.json
@@ -14,8 +14,6 @@
   },
   "scripts": {
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app",
     "test": "npm run system-test"
   },
@@ -24,8 +22,7 @@
     "express": "4.16.4"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^3.0.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/endpoints/package.json b/appengine/endpoints/package.json
@@ -10,13 +10,11 @@
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
   "engines": {
-    "node": ">=4.3.2"
+    "node": ">=8.0.0"
   },
   "scripts": {
     "deploy": "gcloud app deploy",
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "unit-test": "ava --verbose test/*.test.js",
     "system-test": "repo-tools test app",
     "all-test": "npm run unit-test && npm run system-test",
@@ -31,6 +29,8 @@
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
     "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   }
 }
diff --git a/appengine/errorreporting/app.js b/appengine/errorreporting/app.js
@@ -24,7 +24,7 @@ app.get('/', (req, res, next) => {
   next(new Error('something is wrong!'));
 });
 
-app.use((err, req, res, next) => {
+app.use((err, req, res) => {
   errors.report(err);
   res.status(500).send(err.message || 'Something broke!');
 });
diff --git a/appengine/errorreporting/package.json b/appengine/errorreporting/package.json
@@ -14,8 +14,6 @@
   },
   "scripts": {
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "unit-test": "ava --verbose test/*.test.js",
     "system-test": "repo-tools test app",
     "test": "npm run unit-test && npm run system-test"
@@ -28,8 +26,8 @@
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
     "ava": "0.25.0",
     "proxyquire": "2.0.0",
-    "semistandard": "^12.0.1",
-    "sinon": "4.4.2"
+    "sinon": "4.4.2",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/headless-chrome/package.json b/appengine/headless-chrome/package.json
@@ -9,8 +9,6 @@
     "start": "node app.js",
     "system-test": "repo-tools test app",
     "unit-test": "ava --verbose test/*.test.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "test": "npm run unit-test && npm run system-test"
   },
   "repository": {
@@ -27,8 +25,7 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "ava": "^0.25.0",
-    "semistandard": "^12.0.1"
+    "ava": "^0.25.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/hello-world/flexible/package.json b/appengine/hello-world/flexible/package.json
@@ -10,13 +10,11 @@
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
   "engines": {
-    "node": ">=4.3.2"
+    "node": ">=8.0.0"
   },
   "scripts": {
     "deploy": "gcloud app deploy",
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app",
     "test": "npm run system-test",
     "e2e-test": "repo-tools test deploy"
@@ -25,8 +23,7 @@
     "express": "^4.16.3"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^2.3.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^2.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/hello-world/standard/package.json b/appengine/hello-world/standard/package.json
@@ -15,8 +15,6 @@
   "scripts": {
     "deploy": "gcloud app deploy",
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app",
     "test": "npm run system-test",
     "e2e-test": "repo-tools test deploy"
@@ -25,8 +23,7 @@
     "express": "^4.16.3"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^2.3.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^2.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/mailjet/package.json b/appengine/mailjet/package.json
@@ -14,9 +14,6 @@
   },
   "scripts": {
     "start": "node app.js",
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
-    "system-test": "repo-tools test app",
     "test": "npm run system-test"
   },
   "dependencies": {
@@ -26,8 +23,7 @@
     "node-mailjet": "3.2.1"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^2.3.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^2.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/metadata/flexible/package.json b/appengine/metadata/flexible/package.json
@@ -13,8 +13,6 @@
     "node": ">=8"
   },
   "scripts": {
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app -- server.js",
     "test": "npm run system-test"
   },
@@ -23,8 +21,7 @@
     "got": "8.3.2"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^2.3.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^2.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/metadata/standard/package.json b/appengine/metadata/standard/package.json
@@ -13,8 +13,6 @@
     "node": ">=8"
   },
   "scripts": {
-    "lint": "semistandard '**/*.js'",
-    "pretest": "npm run lint",
     "system-test": "repo-tools test app -- ./server.js",
     "test": "npm run system-test"
   },
@@ -23,8 +21,7 @@
     "got": "8.3.2"
   },
   "devDependencies": {
-    "@google-cloud/nodejs-repo-tools": "^2.3.0",
-    "semistandard": "^12.0.1"
+    "@google-cloud/nodejs-repo-tools": "^2.3.0"
   },
   "cloud-repo-tools": {
     "test": {
diff --git a/appengine/storage/flexible/package.json b/appengine/storage/flexible/package.json
@@ -6,7 +6,7 @@
     "test": "ava system-test/*.test.js -T 30s"
   },
   "engines": {
-    "node": ">=4.3.2"
+    "node": ">=8.0.0"
   },
   "dependencies": {
     "@google-cloud/storage": "1.6.0",
diff --git a/appengine/storage/flexible/system-test/.eslintrc.yaml b/appengine/storage/flexible/system-test/.eslintrc.yaml
@@ -0,0 +1,3 @@
+---
+rules:
+  no-empty: off
diff --git a/appengine/storage/flexible/system-test/app.test.js b/appengine/storage/flexible/system-test/app.test.js
@@ -27,7 +27,7 @@ const requestObj = utils.getRequest({cwd: cwd});
 
 test.before(async () => {
   utils.checkCredentials();
-  await bucket.create(bucket).then(data => {
+  await bucket.create(bucket).then(() => {
     return bucket.acl.add({
       entity: 'allUsers',
       role: Storage.acl.READER_ROLE,
diff --git a/appengine/storage/standard/system-test/.eslintrc.yaml b/appengine/storage/standard/system-test/.eslintrc.yaml
@@ -0,0 +1,3 @@
+---
+rules:
+  no-empty: off
diff --git a/appengine/storage/standard/system-test/app.test.js b/appengine/storage/standard/system-test/app.test.js
@@ -27,7 +27,7 @@ const requestObj = utils.getRequest({cwd: cwd});
 
 test.before(async () => {
   utils.checkCredentials();
-  await bucket.create(bucket).then(data => {
+  await bucket.create(bucket).then(() => {
     return bucket.acl.add({
       entity: 'allUsers',
       role: Storage.acl.READER_ROLE,
diff --git a/appengine/system-test/all.test.js b/appengine/system-test/all.test.js
@@ -26,7 +26,7 @@ var sampleTests = [
     msg: 'Hello World! Express.js + Grunt.js on Google App Engine.',
     TRAVIS_NODE_VERSION: '0.12',
   },
-  // TODO: Investigate flaky test
+  // Investigate flaky test
   // {
   //   dir: 'appengine/loopback',
   //   cmd: 'node',
diff --git a/appengine/twilio/app.js b/appengine/twilio/app.js
@@ -28,7 +28,9 @@ if (!TWILIO_NUMBER) {
   console.log(
     'Please configure environment variables as described in README.md'
   );
-  process.exit(1);
+  throw new Error(
+    'Please configure environment variables as described in README.md'
+  );
 }
 
 const twilio = require('twilio')(
diff --git a/appengine/typescript/package.json b/appengine/typescript/package.json
@@ -6,7 +6,7 @@
   "license": "Apache Version 2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": "8.x"
+    "node": ">=8.0.0"
   },
   "scripts": {
     "test": "npm run gcp-build && npm run lint && repo-tools test app -- index.js",
@@ -21,7 +21,6 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^2.3.3",
-    "semistandard": "^12.0.1",
     "tslint": "^5.11.0"
   }
 }
diff --git a/appengine/uglifyjs/package.json b/appengine/uglifyjs/package.json
diff --git a/appengine/uglifyjs/static/.eslintrc.yaml b/appengine/uglifyjs/static/.eslintrc.yaml
