checkstyle: violations were in overlapped netty classes.

KostyaSha · KostyaSha · commit d5d77ad81c35 · 2016-02-03T03:44:18.000+03:00
diff --git a/src/main/java/com/github/dockerjava/netty/exec/CommitCmdExec.java b/src/main/java/com/github/dockerjava/netty/exec/CommitCmdExec.java
@@ -27,8 +27,8 @@ protected String execute(CommitCmd command) {
         webTarget = booleanQueryParam(webTarget, "pause", command.hasPauseEnabled());
 
         LOGGER.trace("POST: {}", webTarget);
-        ObjectNode objectNode = webTarget.request().accept(MediaType.APPLICATION_JSON).
-                post(command, new TypeReference<ObjectNode>() {});
+        ObjectNode objectNode = webTarget.request().accept(MediaType.APPLICATION_JSON)
+                .post(command, new TypeReference<ObjectNode>() { });
 
         return objectNode.get("Id").asText();
     }
diff --git a/src/main/java/com/github/dockerjava/netty/exec/CreateImageCmdExec.java b/src/main/java/com/github/dockerjava/netty/exec/CreateImageCmdExec.java
@@ -26,6 +26,6 @@ protected CreateImageResponse execute(CreateImageCmd command) {
 
         LOGGER.trace("POST: {}", webResource);
         return webResource.request().accept(MediaType.APPLICATION_OCTET_STREAM)
-                .post(new TypeReference<CreateImageResponse>() {}, command.getImageStream());
+                .post(new TypeReference<CreateImageResponse>() { }, command.getImageStream());
     }
 }
diff --git a/src/test/resources/checkstyle/checkstyle-config.xml b/src/test/resources/checkstyle/checkstyle-config.xml
@@ -98,8 +98,7 @@
 
         <!-- Checks for whitespace                               -->
         <!-- See http://checkstyle.sf.net/config_whitespace.html -->
-        <!-- @KostyaSha unsure -->
-        <!--<module name="EmptyForIteratorPad"/>-->
+        <module name="EmptyForIteratorPad"/>
         <module name="MethodParamPad"/>
         <module name="NoWhitespaceAfter"/>
         <module name="NoWhitespaceBefore"/>
@@ -111,7 +110,7 @@
         <module name="TypecastParenPad"/>
         <module name="WhitespaceAfter"/>
         <!-- some weirdness with logger in CommitCmdExec and CreateImageCmdExec -->
-        <!--<module name="WhitespaceAround"/>-->
+        <module name="WhitespaceAround"/>
 
         <!-- Modifier Checks                                    -->
         <!-- See http://checkstyle.sf.net/config_modifiers.html -->

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ protected String execute(CommitCmd command) {`
`27`	`27`	`webTarget = booleanQueryParam(webTarget, "pause", command.hasPauseEnabled());`
`28`	`28`
`29`	`29`	`LOGGER.trace("POST: {}", webTarget);`
`30`		`- ObjectNode objectNode = webTarget.request().accept(MediaType.APPLICATION_JSON).`
`31`		`- post(command, new TypeReference<ObjectNode>() {});`
	`30`	`+ ObjectNode objectNode = webTarget.request().accept(MediaType.APPLICATION_JSON)`
	`31`	`+ .post(command, new TypeReference<ObjectNode>() { });`
`32`	`32`
`33`	`33`	`return objectNode.get("Id").asText();`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,6 @@ protected CreateImageResponse execute(CreateImageCmd command) {`
`26`	`26`
`27`	`27`	`LOGGER.trace("POST: {}", webResource);`
`28`	`28`	`return webResource.request().accept(MediaType.APPLICATION_OCTET_STREAM)`
`29`		`- .post(new TypeReference<CreateImageResponse>() {}, command.getImageStream());`
	`29`	`+ .post(new TypeReference<CreateImageResponse>() { }, command.getImageStream());`
`30`	`30`	`}`
`31`	`31`	`}`