Fix ListSwarmNodesCmdImpl and Add basic tests (docker-java#1385)

klmntoth · bsideup · web-flow · commit a5b9b0be5722 · 2020-05-25T09:03:57.000+02:00
* Fix ListSwarmNodesCmdImpl and Add basic tests

- fixes withMembershipsFilter
- fixes withRoleFilter
- adds basic tests for the class.

* Update docker-java/src/test/java/com/github/dockerjava/cmd/swarm/ListSwarmNodesCmdExecIT.java

* Update ListSwarmNodesCmdExecIT.java

* use `startSwarm()`

Co-authored-by: Sergei Egorov &lt;segorov@pivotal.io&gt;
Co-authored-by: Sergei Egorov &lt;bsideup@gmail.com&gt;
diff --git a/docker-java-core/src/main/java/com/github/dockerjava/core/command/ListSwarmNodesCmdImpl.java b/docker-java-core/src/main/java/com/github/dockerjava/core/command/ListSwarmNodesCmdImpl.java
@@ -44,14 +44,14 @@ public ListSwarmNodesCmd withNameFilter(List<String> names) {
     @Override
     public ListSwarmNodesCmd withMembershipFilter(List<String> memberships) {
         checkNotNull(memberships, "memberships was not specified");
-        this.filters.withNames(memberships);
+        this.filters.withMemberships(memberships);
         return this;
     }
 
     @Override
     public ListSwarmNodesCmd withRoleFilter(List<String> roles) {
         checkNotNull(roles, "roles was not specified");
-        this.filters.withNames(roles);
+        this.filters.withRoles(roles);
         return this;
     }
 }
diff --git a/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/ListSwarmNodesCmdExecIT.java b/docker-java/src/test/java/com/github/dockerjava/cmd/swarm/ListSwarmNodesCmdExecIT.java
@@ -0,0 +1,89 @@
+package com.github.dockerjava.cmd.swarm;
+
+import com.github.dockerjava.api.DockerClient;
+import com.github.dockerjava.api.model.SwarmNode;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+
+public class ListSwarmNodesCmdExecIT extends SwarmCmdIT {
+    @Test
+    public void testListSwarmNodes() throws Exception {
+        DockerClient dockerClient = startSwarm();
+
+        List<SwarmNode> nodes = dockerClient.listSwarmNodesCmd().exec();
+        assertThat(nodes.size(), is(1));
+    }
+
+    @Test
+    public void testListSwarmNodesWithIdFilter() throws Exception {
+        DockerClient dockerClient = startSwarm();
+
+        List<SwarmNode> nodes = dockerClient.listSwarmNodesCmd().exec();
+        assertThat(nodes.size(), is(1));
+
+        String nodeId = nodes.get(0).getId();
+        List<SwarmNode> nodesWithId = dockerClient.listSwarmNodesCmd()
+            .withIdFilter(Collections.singletonList(nodeId))
+            .exec();
+        assertThat(nodesWithId.size(), is(1));
+
+        List<SwarmNode> nodesWithNonexistentId = dockerClient.listSwarmNodesCmd()
+            .withIdFilter(Collections.singletonList("__nonexistent__"))
+            .exec();
+        assertThat(nodesWithNonexistentId.size(), is(0));
+    }
+
+    @Test
+    public void testListSwarmNodesWithNameFilter() throws Exception {
+        DockerClient dockerClient = startSwarm();
+
+        List<SwarmNode> nodes = dockerClient.listSwarmNodesCmd().exec();
+        assertThat(nodes.size(), is(1));
+
+        String nodeName = nodes.get(0).getSpec().getName();
+        List<SwarmNode> nodesWithFirstNodesName = dockerClient.listSwarmNodesCmd()
+            .withNameFilter(Collections.singletonList(nodeName))
+            .exec();
+        assertThat(nodesWithFirstNodesName.size(), is(1));
+
+        List<SwarmNode> nodesWithNonexistentName = dockerClient.listSwarmNodesCmd()
+            .withNameFilter(Collections.singletonList("__nonexistent__"))
+            .exec();
+        assertThat(nodesWithNonexistentName.size(), is(0));
+    }
+
+    @Test
+    public void testListSwarmNodesWithMembershipFilter() throws Exception {
+        DockerClient dockerClient = startSwarm();
+
+        List<SwarmNode> nodesWithAcceptedMembership = dockerClient.listSwarmNodesCmd()
+            .withMembershipFilter(Collections.singletonList("accepted"))
+            .exec();
+        assertThat(nodesWithAcceptedMembership.size(), is(1));
+
+        List<SwarmNode> nodesWithPendingMembership = dockerClient.listSwarmNodesCmd()
+            .withMembershipFilter(Collections.singletonList("pending"))
+            .exec();
+        assertThat(nodesWithPendingMembership.size(), is(0));
+    }
+
+    @Test
+    public void testListSwarmNodesWithRoleFilter() throws Exception {
+        DockerClient dockerClient = startSwarm();
+
+        List<SwarmNode> nodesWithManagerRole = dockerClient.listSwarmNodesCmd()
+            .withRoleFilter(Collections.singletonList("manager"))
+            .exec();
+        assertThat(nodesWithManagerRole.size(), is(1));
+
+        List<SwarmNode> nodesWithWorkerRole = dockerClient.listSwarmNodesCmd()
+            .withRoleFilter(Collections.singletonList("worker"))
+            .exec();
+        assertThat(nodesWithWorkerRole.size(), is(0));
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -44,14 +44,14 @@ public ListSwarmNodesCmd withNameFilter(List<String> names) {`
`44`	`44`	`@Override`
`45`	`45`	`public ListSwarmNodesCmd withMembershipFilter(List<String> memberships) {`
`46`	`46`	`checkNotNull(memberships, "memberships was not specified");`
`47`		`- this.filters.withNames(memberships);`
	`47`	`+ this.filters.withMemberships(memberships);`
`48`	`48`	`return this;`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`@Override`
`52`	`52`	`public ListSwarmNodesCmd withRoleFilter(List<String> roles) {`
`53`	`53`	`checkNotNull(roles, "roles was not specified");`
`54`		`- this.filters.withNames(roles);`
	`54`	`+ this.filters.withRoles(roles);`
`55`	`55`	`return this;`
`56`	`56`	`}`
`57`	`57`	`}`