From db6dea225570dd6e8a583e3b8c1f12c7dadddd4b Mon Sep 17 00:00:00 2001 From: sockstack <85564748@qq.com> Date: Wed, 7 Nov 2018 15:58:03 +0000 Subject: [PATCH] Apply fixes from StyleCI --- src/SimpleFactory/Sample/Driver/DriverInterface.php | 5 ++--- src/SimpleFactory/Sample/Driver/MysqlDriver.php | 6 ++---- src/SimpleFactory/Sample/Driver/MysqliDriver.php | 6 ++---- src/SimpleFactory/Sample/SimpleFactory.php | 9 +++++---- tests/SimpleFactoryTest.php | 11 +++++------ 5 files changed, 16 insertions(+), 21 deletions(-) diff --git a/src/SimpleFactory/Sample/Driver/DriverInterface.php b/src/SimpleFactory/Sample/Driver/DriverInterface.php index 7c33309..42ae0f4 100644 --- a/src/SimpleFactory/Sample/Driver/DriverInterface.php +++ b/src/SimpleFactory/Sample/Driver/DriverInterface.php @@ -3,13 +3,12 @@ * Created by PhpStorm. * User: sockstack * Date: 2018/11/7 - * Time: 23:40 + * Time: 23:40. */ namespace Sockstack\DesignPattern\SimpleFactory\Sample\Driver; - interface DriverInterface { public function connection(); -} \ No newline at end of file +} diff --git a/src/SimpleFactory/Sample/Driver/MysqlDriver.php b/src/SimpleFactory/Sample/Driver/MysqlDriver.php index f44bc00..b2aaff6 100644 --- a/src/SimpleFactory/Sample/Driver/MysqlDriver.php +++ b/src/SimpleFactory/Sample/Driver/MysqlDriver.php @@ -3,17 +3,15 @@ * Created by PhpStorm. * User: sockstack * Date: 2018/11/7 - * Time: 23:40 + * Time: 23:40. */ namespace Sockstack\DesignPattern\SimpleFactory\Sample\Driver; - class MysqlDriver implements DriverInterface { - public function connection() { // TODO: Implement connection() method. } -} \ No newline at end of file +} diff --git a/src/SimpleFactory/Sample/Driver/MysqliDriver.php b/src/SimpleFactory/Sample/Driver/MysqliDriver.php index 776f8e1..1433980 100644 --- a/src/SimpleFactory/Sample/Driver/MysqliDriver.php +++ b/src/SimpleFactory/Sample/Driver/MysqliDriver.php @@ -3,17 +3,15 @@ * Created by PhpStorm. * User: sockstack * Date: 2018/11/7 - * Time: 23:41 + * Time: 23:41. */ namespace Sockstack\DesignPattern\SimpleFactory\Sample\Driver; - class MysqliDriver implements DriverInterface { - public function connection() { // TODO: Implement connection() method. } -} \ No newline at end of file +} diff --git a/src/SimpleFactory/Sample/SimpleFactory.php b/src/SimpleFactory/Sample/SimpleFactory.php index a850a83..55d05c3 100644 --- a/src/SimpleFactory/Sample/SimpleFactory.php +++ b/src/SimpleFactory/Sample/SimpleFactory.php @@ -3,19 +3,19 @@ * Created by PhpStorm. * User: sockstack * Date: 2018/11/7 - * Time: 23:34 + * Time: 23:34. */ namespace Sockstack\DesignPattern\SimpleFactory\Sample; - use Sockstack\DesignPattern\SimpleFactory\Sample\Driver\MysqlDriver; use Sockstack\DesignPattern\SimpleFactory\Sample\Driver\MysqliDriver; class SimpleFactory { /** - * 返回mysql实例 + * 返回mysql实例. + * * @return MysqlDriver */ public static function createMysql() @@ -24,7 +24,8 @@ public static function createMysql() } /** - * 返回mysqli实例 + * 返回mysqli实例. + * * @return MysqliDriver */ public static function createMysqli() diff --git a/tests/SimpleFactoryTest.php b/tests/SimpleFactoryTest.php index 54539d5..5ffda00 100644 --- a/tests/SimpleFactoryTest.php +++ b/tests/SimpleFactoryTest.php @@ -3,15 +3,14 @@ * Created by PhpStorm. * User: sockstack * Date: 2018/11/7 - * Time: 23:43 + * Time: 23:43. */ namespace Sockstack\DesignPattern\Test; - use PHPUnit\Framework\TestCase; -use Sockstack\DesignPattern\SimpleFactory\Sample\Driver\MysqliDriver; use Sockstack\DesignPattern\SimpleFactory\Sample\Driver\MysqlDriver; +use Sockstack\DesignPattern\SimpleFactory\Sample\Driver\MysqliDriver; use Sockstack\DesignPattern\SimpleFactory\Sample\SimpleFactory; class SimpleFactoryTest extends TestCase @@ -20,12 +19,12 @@ public function testSimpleFactory() { $mysql = SimpleFactory::createMysql(); if (!$mysql instanceof MysqlDriver) { - $this->fail("创建实例对象失败"); + $this->fail('创建实例对象失败'); } $mysqli = SimpleFactory::createMysqli(); if (!$mysqli instanceof MysqliDriver) { - $this->fail("创建实例对象失败"); + $this->fail('创建实例对象失败'); } } -} \ No newline at end of file +}