Repository navigation
fix: subresource integrity - #803
Conversation
| }, | ||
| ) | ||
| }) | ||
|
|
There was a problem hiding this comment.
checked - SriPlugin extends assets information at PROCESS_ASSETS_STAGE_OPTIMIZE_HASH stage, so at PROCESS_ASSETS_STAGE_REPORT all extra fields should be already a part of stats.
There was a problem hiding this comment.
youre right, thanks! i wasnt seeing the integrity available at this stage before but i must have been looking in the wrong place at the time
theKashey
left a comment
There was a problem hiding this comment.
There should be close to zero changes around LoadablePlugin.apply
done, thanks for the feedback! |
8087d1d to
a2139be
Compare
theKashey
left a comment
There was a problem hiding this comment.
Wow it's really simple now! I'll review it shortly
a2139be to
f1a4a6f
Compare
|
hey @theKashey, just checking if youve had a chance to take another look? currently i wrote a new plugin to do this work for our project but i would prefer not to keep it around. thanks! |
|
Verified and merged. 👍 |
|
thank you @theKashey! any chance for a new release with this in it? |
Summary
this pull request solves the problem of integrity not being added to script tags when using
webpack-subresource-integrity. it seems that either #436 did not include everything necessary or possibly my configuration is different but i was unable to get things working properly without these changes. other users are seeing this issue as well as seen in #563Test plan
webpack-subresource-integrityto your webpack pluginsintegrityattribute inloadable-stats.jsonand on yourscripttags when usingChunkExtractor.getScriptTags