BridJ: Add BRIDJ_WARN_STRUCT_FIELDS=0 / -Dbridj.warnStructFields=false to mute obnoxious warning

ochafik · ochafik · commit 3e2873e17c4e · 2015-03-07T23:53:28.000Z
diff --git a/libraries/BridJ/src/main/java/org/bridj/BridJ.java b/libraries/BridJ/src/main/java/org/bridj/BridJ.java
@@ -403,6 +403,8 @@ enum Switch {
         "Align doubles on 8 bytes boundaries even on Linux 32 bits (see -malign-double GCC option)."),
         LogCalls("bridj.logCalls", "BRIDJ_LOG_CALLS", false,
         "Log each native call performed (or call from native to Java callback)"),
+        WarnStructFields("bridj.warnStructFields", "BRIDJ_WARN_STRUCT_FIELDS", true,
+        "Warn when struct fields are implemented with Java fields instead of methods")
         Protected("bridj.protected", "BRIDJ_PROTECTED", false,
         "Protect all native calls (including memory accesses) against native crashes (disables assembly optimizations and adds quite some overhead)."),
         Destructors("bridj.destructors", "BRIDJ_DESTRUCTORS", true,
@@ -498,6 +500,7 @@ static void checkOptions() {
     public static final boolean verbose = debug || veryVerbose || Switch.Verbose.enabled;
     public static final boolean quiet = Switch.Quiet.enabled;
     public static final boolean logCalls = Switch.LogCalls.enabled;
+    public static final boolean warnStructFields = Switch.LogCalls.enabled;
     public static final boolean protectedMode = Switch.Protected.enabled;
     public static final boolean enableDestructors = Switch.Destructors.enabled;
     public static final boolean alignDoubles = Switch.AlignDouble.enabled;
diff --git a/libraries/BridJ/src/main/java/org/bridj/StructFieldDeclaration.java b/libraries/BridJ/src/main/java/org/bridj/StructFieldDeclaration.java
@@ -102,8 +102,8 @@ protected static List<StructFieldDeclaration> listFields(Class<?> structClass) {
                 }
             }
         }
-        if (nFieldFields > 0) {
-            BridJ.warning("Struct " + structClass.getName() + " has " + nFieldFields + " struct fields implemented as Java fields, which won't give the best performance and might require counter-intuitive calls to BridJ.readFromNative / .writeToNative. Please consider using JNAerator to generate your struct instead.");
+        if (nFieldFields > 0 && BridJ.warnStructFields) {
+            BridJ.warning("Struct " + structClass.getName() + " has " + nFieldFields + " struct fields implemented as Java fields, which won't give the best performance and might require counter-intuitive calls to BridJ.readFromNative / .writeToNative. Please consider using JNAerator to generate your struct instead, or use BRIDJ_WARN_STRUCT_FIELDS=0 or -Dbridj.warnStructFields=false to mute this warning.");
         }
 
         return list;

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,8 @@ protected static List<StructFieldDeclaration> listFields(Class<?> structClass) {`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`	`}`
`105`		`- if (nFieldFields > 0) {`
`106`		`- BridJ.warning("Struct " + structClass.getName() + " has " + nFieldFields + " struct fields implemented as Java fields, which won't give the best performance and might require counter-intuitive calls to BridJ.readFromNative / .writeToNative. Please consider using JNAerator to generate your struct instead.");`
	`105`	`+ if (nFieldFields > 0 && BridJ.warnStructFields) {`
	`106`	`+ BridJ.warning("Struct " + structClass.getName() + " has " + nFieldFields + " struct fields implemented as Java fields, which won't give the best performance and might require counter-intuitive calls to BridJ.readFromNative / .writeToNative. Please consider using JNAerator to generate your struct instead, or use BRIDJ_WARN_STRUCT_FIELDS=0 or -Dbridj.warnStructFields=false to mute this warning.");`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`return list;`