Skip to content

Commit cd0c4e1

Browse files
Wade AndersonWade Anderson
authored andcommitted
Final touches on README
1 parent 87b0d76 commit cd0c4e1

5 files changed

Lines changed: 22 additions & 19 deletions

File tree

.vscode/tasks.json

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,8 @@
1616
"args": ["update"]
1717
},
1818
{
19-
"taskName": "test",
20-
"args": ["run", "test"]
21-
},
22-
{
23-
"taskName": "build",
24-
"args": ["run", "build"],
25-
"isBuildCommand": true
19+
"taskName": "serve",
20+
"args": ["run", "serve"]
2621
},
2722
{
2823
"taskName": "dev",

README.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,17 @@
33
This demo shows the core functionality of [Visual Studio Code](https://code.visualstudio.com)
44
for Build 2016 session workshop.
55

6+
![todo demo](/media/todo_demo.gif)
7+
68
## Getting Started
79

810
```bash
11+
# clone repo
12+
git clone https://github.com/Microsoft/react-todo.git
13+
14+
# navigate to repo
15+
cd react-todo
16+
917
# install deps
1018
npm install
1119
```
@@ -41,11 +49,13 @@ server. This will become more robust overtime.
4149
}
4250
```
4351

44-
> Obviously, this type of database isn't scalable.
52+
## Not meant for production
4553

46-
## Demo
54+
There are a couple of issues to fix before this code base should
55+
be used as a model for a production ready application.
4756

48-
![todo demo](/media/todo_demo.gif)
57+
* Swap out the file based data model for a real data backend.
58+
* Replace webpack dev server with an application server or serve up the app with the Node server.
4959

5060
## Technologies
5161

data/todos.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
{
22
"todos": [
3-
{
4-
"text": "x",
5-
"id": 22
6-
}
73
]
84
}

media/todo_demo.gif

-439 KB
Loading

package.json

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"scripts": {
77
"build": "webpack --config webpack.config.js",
88
"dev": "webpack-dev-server --config webpack.config.js --open",
9-
"server": "node server/server.js"
9+
"serve": "node server/server.js"
1010
},
1111
"author": "waderyan",
1212
"license": "MIT",
@@ -16,14 +16,18 @@
1616
"babel-preset-es2015": "^6.5.0",
1717
"babel-preset-react": "^6.5.0",
1818
"babel-preset-stage-0": "^6.5.0",
19-
"html-webpack-plugin": "^2.8.1",
19+
"css-loader": "^0.23.1",
20+
"html-webpack-plugin": "^2.14.0",
2021
"node-sass": "^3.4.2",
2122
"sass-loader": "^3.2.0",
23+
"style-loader": "^0.13.1",
2224
"webpack": "^1.12.14",
2325
"webpack-dev-server": "^1.14.1"
2426
},
2527
"dependencies": {
28+
"body-parser": "^1.15.0",
2629
"classnames": "^2.2.3",
30+
"express": "^4.13.4",
2731
"file-loader": "^0.8.5",
2832
"imports-loader": "^0.6.5",
2933
"jquery": "^2.2.2",
@@ -34,8 +38,6 @@
3438
"react-tap-event-plugin": "^0.2.2",
3539
"resolve-url-loader": "^1.4.3",
3640
"tether": "^1.2.0",
37-
"url-loader": "^0.5.7",
38-
"body-parser": "^1.15.0",
39-
"express": "^4.13.4"
41+
"url-loader": "^0.5.7"
4042
}
4143
}

0 commit comments

Comments
 (0)