Use col offset in bandit output to tag the correct node in the AST (microsoft#15003)

tonybaloney · web-flow · commit cd42b50cabbe · 2021-01-07T15:39:18.000-08:00
* Use col offset in bandit output

* Add news item

* Format linter input to keep the linter happy

* Update test assertion for bandit call
diff --git a/news/1 Enhancements/15003.md b/news/1 Enhancements/15003.md
@@ -0,0 +1,3 @@
+Integration with the bandit linter will highlight the variable, function or method for an issue instead of the entire line.
+Requires latest version of the bandit package to be installed.
+(thanks [Anthony Shaw](https://github.com/tonybaloney))
diff --git a/src/client/linters/bandit.ts b/src/client/linters/bandit.ts
@@ -24,7 +24,15 @@ export class Bandit extends BaseLinter {
     protected async runLinter(document: TextDocument, cancellation: CancellationToken): Promise<ILintMessage[]> {
         // View all errors in bandit <= 1.5.1 (https://github.com/PyCQA/bandit/issues/371)
         const messages = await this.run(
-            ['-f', 'custom', '--msg-template', '{line},0,{severity},{test_id}:{msg}', '-n', '-1', document.uri.fsPath],
+            [
+                '-f',
+                'custom',
+                '--msg-template',
+                '{line},{col},{severity},{test_id}:{msg}',
+                '-n',
+                '-1',
+                document.uri.fsPath
+            ],
             document,
             cancellation,
         );
diff --git a/src/test/linters/lint.args.test.ts b/src/test/linters/lint.args.test.ts
@@ -200,7 +200,7 @@ suite('Linting - Arguments', () => {
                             '-f',
                             'custom',
                             '--msg-template',
-                            '{line},0,{severity},{test_id}:{msg}',
+                            '{line},{col},{severity},{test_id}:{msg}',
                             '-n',
                             '-1',
                             fileUri.fsPath,

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Integration with the bandit linter will highlight the variable, function or method for an issue instead of the entire line.`
	`2`	`+Requires latest version of the bandit package to be installed.`
	`3`	`+(thanks [Anthony Shaw](https://github.com/tonybaloney))`