Merge pull request #1427 from dolmen/fix-testify-usage

thaJeztah · web-flow · commit d9168199e068 · 2025-08-04T16:29:58.000+02:00
testing: fix usage of the Testify API
diff --git a/entry_test.go b/entry_test.go
@@ -241,20 +241,20 @@ func TestEntryWithIncorrectField(t *testing.T) {
 	eWithFunc := e.WithFields(Fields{"func": fn})
 	eWithFuncPtr := e.WithFields(Fields{"funcPtr": &fn})
 
-	assert.Equal(eWithFunc.err, `can not add field "func"`)
-	assert.Equal(eWithFuncPtr.err, `can not add field "funcPtr"`)
+	assert.Equal(`can not add field "func"`, eWithFunc.err)
+	assert.Equal(`can not add field "funcPtr"`, eWithFuncPtr.err)
 
 	eWithFunc = eWithFunc.WithField("not_a_func", "it is a string")
 	eWithFuncPtr = eWithFuncPtr.WithField("not_a_func", "it is a string")
 
-	assert.Equal(eWithFunc.err, `can not add field "func"`)
-	assert.Equal(eWithFuncPtr.err, `can not add field "funcPtr"`)
+	assert.Equal(`can not add field "func"`, eWithFunc.err)
+	assert.Equal(`can not add field "funcPtr"`, eWithFuncPtr.err)
 
 	eWithFunc = eWithFunc.WithTime(time.Now())
 	eWithFuncPtr = eWithFuncPtr.WithTime(time.Now())
 
-	assert.Equal(eWithFunc.err, `can not add field "func"`)
-	assert.Equal(eWithFuncPtr.err, `can not add field "funcPtr"`)
+	assert.Equal(`can not add field "func"`, eWithFunc.err)
+	assert.Equal(`can not add field "funcPtr"`, eWithFuncPtr.err)
 }
 
 func TestEntryLogfLevel(t *testing.T) {
diff --git a/hook_test.go b/hook_test.go
@@ -41,11 +41,11 @@ func TestHookFires(t *testing.T) {
 
 	LogAndAssertJSON(t, func(log *Logger) {
 		log.Hooks.Add(hook)
-		assert.Equal(t, hook.Fired, false)
+		assert.False(t, hook.Fired)
 
 		log.Print("test")
 	}, func(fields Fields) {
-		assert.Equal(t, hook.Fired, true)
+		assert.True(t, hook.Fired)
 	})
 }
 
@@ -76,7 +76,7 @@ func TestHookCanModifyEntry(t *testing.T) {
 		log.Hooks.Add(hook)
 		log.WithField("wow", "elephant").Print("test")
 	}, func(fields Fields) {
-		assert.Equal(t, fields["wow"], "whale")
+		assert.Equal(t, "whale", fields["wow"])
 	})
 }
 
@@ -90,8 +90,8 @@ func TestCanFireMultipleHooks(t *testing.T) {
 
 		log.WithField("wow", "elephant").Print("test")
 	}, func(fields Fields) {
-		assert.Equal(t, fields["wow"], "whale")
-		assert.Equal(t, hook2.Fired, true)
+		assert.Equal(t, "whale", fields["wow"])
+		assert.True(t, hook2.Fired)
 	})
 }
 
@@ -157,7 +157,7 @@ func TestErrorHookShouldntFireOnInfo(t *testing.T) {
 		log.Hooks.Add(hook)
 		log.Info("test")
 	}, func(fields Fields) {
-		assert.Equal(t, hook.Fired, false)
+		assert.False(t, hook.Fired)
 	})
 }
 
@@ -168,7 +168,7 @@ func TestErrorHookShouldFireOnError(t *testing.T) {
 		log.Hooks.Add(hook)
 		log.Error("test")
 	}, func(fields Fields) {
-		assert.Equal(t, hook.Fired, true)
+		assert.True(t, hook.Fired)
 	})
 }
 
diff --git a/hooks/writer/writer_test.go b/hooks/writer/writer_test.go
@@ -33,6 +33,6 @@ func TestDifferentLevelsGoToDifferentWriters(t *testing.T) {
 	log.Warn("send to a")
 	log.Info("send to b")
 
-	assert.Equal(t, a.String(), "level=warning msg=\"send to a\"\n")
-	assert.Equal(t, b.String(), "level=info msg=\"send to b\"\n")
+	assert.Equal(t, "level=warning msg=\"send to a\"\n", a.String())
+	assert.Equal(t, "level=info msg=\"send to b\"\n", b.String())
 }
diff --git a/logger_test.go b/logger_test.go
@@ -70,7 +70,7 @@ func TestWarninglnNotEqualToWarning(t *testing.T) {
 
 type testBufferPool struct {
 	buffers []*bytes.Buffer
-	get int
+	get     int
 }
 
 func (p *testBufferPool) Get() *bytes.Buffer {
@@ -92,6 +92,6 @@ func TestLogger_SetBufferPool(t *testing.T) {
 
 	l.Info("test")
 
-	assert.Equal(t, pool.get, 1, "Logger.SetBufferPool(): The BufferPool.Get() must be called")
+	assert.Equal(t, 1, pool.get, "Logger.SetBufferPool(): The BufferPool.Get() must be called")
 	assert.Len(t, pool.buffers, 1, "Logger.SetBufferPool(): The BufferPool.Put() must be called")
 }
diff --git a/logrus_test.go b/logrus_test.go
diff --git a/writer_test.go b/writer_test.go

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,6 @@ func TestDifferentLevelsGoToDifferentWriters(t *testing.T) {`
`33`	`33`	`log.Warn("send to a")`
`34`	`34`	`log.Info("send to b")`
`35`	`35`
`36`		`- assert.Equal(t, a.String(), "level=warning msg=\"send to a\"\n")`
`37`		`- assert.Equal(t, b.String(), "level=info msg=\"send to b\"\n")`
	`36`	`+ assert.Equal(t, "level=warning msg=\"send to a\"\n", a.String())`
	`37`	`+ assert.Equal(t, "level=info msg=\"send to b\"\n", b.String())`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func TestWarninglnNotEqualToWarning(t *testing.T) {`
`70`	`70`
`71`	`71`	`type testBufferPool struct {`
`72`	`72`	`buffers []*bytes.Buffer`
`73`		`- get int`
	`73`	`+ get int`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`func (p testBufferPool) Get() bytes.Buffer {`
`@@ -92,6 +92,6 @@ func TestLogger_SetBufferPool(t *testing.T) {`
`92`	`92`
`93`	`93`	`l.Info("test")`
`94`	`94`
`95`		`- assert.Equal(t, pool.get, 1, "Logger.SetBufferPool(): The BufferPool.Get() must be called")`
	`95`	`+ assert.Equal(t, 1, pool.get, "Logger.SetBufferPool(): The BufferPool.Get() must be called")`
`96`	`96`	`assert.Len(t, pool.buffers, 1, "Logger.SetBufferPool(): The BufferPool.Put() must be called")`
`97`	`97`	`}`