Skip to content

Commit 0ed2d68

Browse files
gregmalcolmgregmalcolm
committed
Testing with koans passing but inner tests failing
1 parent 676ba37 commit 0ed2d68

3 files changed

Lines changed: 41 additions & 41 deletions

File tree

‎.travis.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ script:
1010
- PYTHON_VER=`python -c 'import sys; print(sys.version_info[0])'`
1111
- cd python$PYTHON_VER
1212
- python _runner_tests.py
13-
- python contemplate_koans.py # Run all the koans
13+
- python contemplate_koans.py about_asserts # Run all the koans
1414
# - python contemplate_koans.py about_asserts about_none # Run a subset of
1515
# # koans
1616
#

‎python2/koans/about_asserts.py‎

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -10,42 +10,42 @@ def test_assert_truth(self):
1010
"""
1111
We shall contemplate truth by testing reality, via asserts.
1212
"""
13-
self.assertTrue(False) # This should be true
14-
15-
def test_assert_with_message(self):
16-
"""
17-
Enlightenment may be more easily achieved with appropriate messages.
18-
"""
19-
self.assertTrue(False, "This should be true -- Please fix this")
20-
21-
def test_fill_in_values(self):
22-
"""
23-
Sometimes we will ask you to fill in the values
24-
"""
25-
self.assertEqual(__, 1 + 1)
26-
27-
def test_assert_equality(self):
28-
"""
29-
To understand reality, we must compare our expectations against
30-
reality.
31-
"""
32-
expected_value = __
33-
actual_value = 1 + 1
34-
self.assertTrue(expected_value == actual_value)
35-
36-
def test_a_better_way_of_asserting_equality(self):
37-
"""
38-
Some ways of asserting equality are better than others.
39-
"""
40-
expected_value = __
41-
actual_value = 1 + 1
42-
43-
self.assertEqual(expected_value, actual_value)
44-
45-
def test_that_unittest_asserts_work_the_same_way_as_python_asserts(self):
46-
"""
47-
Knowing how things really work is half the battle
48-
"""
49-
50-
# This throws an AssertionError exception
51-
assert False
13+
self.assertTrue(True) # This should be true
14+
15+
#def test_assert_with_message(self):
16+
#"""
17+
#Enlightenment may be more easily achieved with appropriate messages.
18+
#"""
19+
#self.assertTrue(False, "This should be true -- Please fix this")
20+
21+
#def test_fill_in_values(self):
22+
#"""
23+
#Sometimes we will ask you to fill in the values
24+
#"""
25+
#self.assertEqual(__, 1 + 1)
26+
27+
#def test_assert_equality(self):
28+
#"""
29+
#To understand reality, we must compare our expectations against
30+
#reality.
31+
#"""
32+
#expected_value = __
33+
#actual_value = 1 + 1
34+
#self.assertTrue(expected_value == actual_value)
35+
36+
#def test_a_better_way_of_asserting_equality(self):
37+
#"""
38+
#Some ways of asserting equality are better than others.
39+
#"""
40+
#expected_value = __
41+
#actual_value = 1 + 1
42+
43+
#self.assertEqual(expected_value, actual_value)
44+
45+
#def test_that_unittest_asserts_work_the_same_way_as_python_asserts(self):
46+
#"""
47+
#Knowing how things really work is half the battle
48+
#"""
49+
50+
## This throws an AssertionError exception
51+
#assert False

‎python2/runner/runner_tests/test_sensei.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,4 +317,4 @@ def test_total_koans_return_43_if_there_are_43_test_cases(self):
317317
def test_filter_all_lessons_will_discover_test_classes_if_none_have_been_discovered_yet(self):
318318
self.sensei.all_lessons = 0
319319
self.assertTrue(len(self.sensei.filter_all_lessons()) > 10)
320-
self.assertTrue(len(self.sensei.all_lessons) > 10)
320+
self.assertTrue(len(self.sensei.all_lessons) < 10)

0 commit comments

Comments
 (0)