From bce8b013a25ab0f1a31e9183fb63e3986da6ae76 Mon Sep 17 00:00:00 2001 From: Siddharth Ganesan Date: Wed, 12 Aug 2026 10:26:51 -0700 Subject: [PATCH] Fix prod desktop release ci --- .github/workflows/ci.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cf2f27d7836..6030c49dba0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -697,7 +697,15 @@ jobs: desktop-release: name: Desktop Release needs: [create-release, check-desktop-signing, detect-version] - if: needs.check-desktop-signing.outputs.configured == 'true' + # Suppress the implicit success() check: check-desktop-signing has an + # intentionally skipped transitive dependency on main, which would + # otherwise cascade-skip this job even when every direct need succeeded. + if: >- + !cancelled() && + needs.create-release.result == 'success' && + needs.check-desktop-signing.result == 'success' && + needs.detect-version.result == 'success' && + needs.check-desktop-signing.outputs.configured == 'true' permissions: contents: write uses: ./.github/workflows/desktop-release.yml