From eec8c1894aff50af3081e0677178b1e70650b3e2 Mon Sep 17 00:00:00 2001 From: Vikhyath Mondreti Date: Mon, 23 Jun 2025 19:23:55 -0700 Subject: [PATCH 1/2] remove unecessary logs --- apps/sim/socket-server/index.ts | 46 ++++++++------------------------- 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/apps/sim/socket-server/index.ts b/apps/sim/socket-server/index.ts index 36f1a2a11df..8d75989cf4d 100644 --- a/apps/sim/socket-server/index.ts +++ b/apps/sim/socket-server/index.ts @@ -294,12 +294,7 @@ async function authenticateSocket(socket: AuthenticatedSocket, next: any) { socket.userEmail = session.user.email socket.activeOrganizationId = session.session.activeOrganizationId || undefined - logger.info(`✅ Socket.IO user authenticated via token: ${socket.id}`, { - userId: session.user.id, - userName: socket.userName, - organizationId: socket.activeOrganizationId, - origin, - }) + next() } catch (tokenError) { const errorMessage = tokenError instanceof Error ? tokenError.message : String(tokenError) @@ -582,7 +577,7 @@ async function persistWorkflowOperation(workflowId: string, operation: any) { } }) - logger.debug(`✅ Persisted ${op} operation on ${target} for workflow ${workflowId}`) + } catch (error) { logger.error( `❌ Error persisting workflow operation (${operation.operation} on ${operation.target}):`, @@ -759,9 +754,7 @@ async function handleSubflowOperationImpl( and(eq(workflowBlocks.id, payload.id), eq(workflowBlocks.workflowId, workflowId)) ) - logger.debug( - `[SERVER] ✅ Also updated loop block ${payload.id} data.count = ${payload.config.iterations}` - ) + } else if (payload.type === 'parallel') { // Update the parallel block's data properties const blockData = { @@ -796,16 +789,10 @@ async function handleSubflowOperationImpl( and(eq(workflowBlocks.id, payload.id), eq(workflowBlocks.workflowId, workflowId)) ) - logger.debug(`[SERVER] ✅ Also updated parallel block ${payload.id} data:`, { - count: payload.config.count, - collection: payload.config.distribution, - parallelType: payload.config.parallelType, - }) + } - logger.debug( - `[SERVER] ✅ Successfully updated subflow ${payload.id} in workflow ${workflowId}` - ) + break } @@ -925,7 +912,7 @@ async function handleBlockOperationImpl( config: subflowConfig, }) - logger.debug(`[SERVER] ✅ Successfully created ${payload.type} subflow ${payload.id}`) + } catch (subflowError) { logger.error( `[SERVER] ❌ Failed to create ${payload.type} subflow ${payload.id}:`, @@ -1075,9 +1062,7 @@ async function handleBlockOperationImpl( and(eq(workflowSubflows.id, payload.id), eq(workflowSubflows.workflowId, workflowId)) ) - logger.debug( - `[SERVER] ✅ Cascade deleted ${childBlocks.length} child blocks and subflow ${payload.id}` - ) + } // Remove any edges connected to this block @@ -1291,12 +1276,7 @@ io.engine.on('connection_error', (err) => { }) io.on('connection', (socket: AuthenticatedSocket) => { - logger.info(`✅ Socket.IO user connected: ${socket.id}`, { - transport: socket.conn.transport.name, - remoteAddress: socket.conn.remoteAddress, - userId: socket.userId, - userName: socket.userName, - }) + // Set up error handling for this socket socket.on('error', (error) => { @@ -1505,9 +1485,7 @@ io.on('connection', (socket: AuthenticatedSocket) => { serverTimestamp, }) - logger.info( - `✅ Operation ${operation} on ${target} in workflow ${workflowId} by user ${session.userId} (${session.userName})` - ) + } catch (error) { if (error instanceof z.ZodError) { socket.emit('operation-error', { @@ -1647,9 +1625,7 @@ io.on('connection', (socket: AuthenticatedSocket) => { }) .where(and(eq(workflowBlocks.id, blockId), eq(workflowBlocks.workflowId, workflowId))) - logger.debug( - `✅ Persisted subblock update: ${workflowId}/${blockId}.${subblockId} = ${JSON.stringify(value)}` - ) + updateSuccessful = true }) @@ -1854,7 +1830,7 @@ logger.info('Starting Socket.IO server...', { }) httpServer.listen(PORT, '0.0.0.0', () => { - logger.info(`✅ Socket.IO server running on port ${PORT}`) + logger.info(`Socket.IO server running on port ${PORT}`) logger.info(`🏥 Health check available at: http://localhost:${PORT}/health`) }) From 842d03212fefb6e079372605ad6ccab880bd9892 Mon Sep 17 00:00:00 2001 From: Vikhyath Mondreti Date: Mon, 23 Jun 2025 19:24:07 -0700 Subject: [PATCH 2/2] fix lint --- apps/sim/socket-server/index.ts | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/apps/sim/socket-server/index.ts b/apps/sim/socket-server/index.ts index 8d75989cf4d..f91e709b2e7 100644 --- a/apps/sim/socket-server/index.ts +++ b/apps/sim/socket-server/index.ts @@ -294,7 +294,6 @@ async function authenticateSocket(socket: AuthenticatedSocket, next: any) { socket.userEmail = session.user.email socket.activeOrganizationId = session.session.activeOrganizationId || undefined - next() } catch (tokenError) { const errorMessage = tokenError instanceof Error ? tokenError.message : String(tokenError) @@ -576,8 +575,6 @@ async function persistWorkflowOperation(workflowId: string, operation: any) { throw new Error(`Unknown operation target: ${target}`) } }) - - } catch (error) { logger.error( `❌ Error persisting workflow operation (${operation.operation} on ${operation.target}):`, @@ -753,8 +750,6 @@ async function handleSubflowOperationImpl( .where( and(eq(workflowBlocks.id, payload.id), eq(workflowBlocks.workflowId, workflowId)) ) - - } else if (payload.type === 'parallel') { // Update the parallel block's data properties const blockData = { @@ -788,11 +783,8 @@ async function handleSubflowOperationImpl( .where( and(eq(workflowBlocks.id, payload.id), eq(workflowBlocks.workflowId, workflowId)) ) - - } - break } @@ -911,8 +903,6 @@ async function handleBlockOperationImpl( type: payload.type, config: subflowConfig, }) - - } catch (subflowError) { logger.error( `[SERVER] ❌ Failed to create ${payload.type} subflow ${payload.id}:`, @@ -1061,8 +1051,6 @@ async function handleBlockOperationImpl( .where( and(eq(workflowSubflows.id, payload.id), eq(workflowSubflows.workflowId, workflowId)) ) - - } // Remove any edges connected to this block @@ -1276,8 +1264,6 @@ io.engine.on('connection_error', (err) => { }) io.on('connection', (socket: AuthenticatedSocket) => { - - // Set up error handling for this socket socket.on('error', (error) => { logger.error(`Socket ${socket.id} error:`, error) @@ -1484,8 +1470,6 @@ io.on('connection', (socket: AuthenticatedSocket) => { operationId: broadcastData.metadata.operationId, serverTimestamp, }) - - } catch (error) { if (error instanceof z.ZodError) { socket.emit('operation-error', { @@ -1625,7 +1609,6 @@ io.on('connection', (socket: AuthenticatedSocket) => { }) .where(and(eq(workflowBlocks.id, blockId), eq(workflowBlocks.workflowId, workflowId))) - updateSuccessful = true })