Skip to content

fix(home,integrations): optical-center home input + integrations page render fix#4916

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/integ-page
Jun 9, 2026
Merged

fix(home,integrations): optical-center home input + integrations page render fix#4916
waleedlatif1 merged 2 commits into
stagingfrom
fix/integ-page

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Fix integrations page crash: the merged email-verification blocks (zerobounce, neverbounce, millionverifier) were serialized with a typo'd integrationTypes: ["sales"] instead of the singular integrationType the catalog reads, so they fell into an undefined bucket and localeCompare threw while sorting sections — erroring the whole page. Corrected the three entries and defensively skip any integration missing integrationType when grouping.
  • Move the home empty-state input to the optical center: vertically center the heading + input as a unit and anchor suggested actions out of flow so expanding/collapsing never shifts the input. Bias the group slightly above true center so the full cluster reads as balanced rather than sagging.

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ge renders

The merged email-verification blocks (zerobounce, neverbounce, millionverifier)
were serialized into integrations.json with a typo'd `integrationTypes: ["sales"]`
plural array instead of the singular `integrationType` the catalog reads. They
fell into an `undefined` category bucket, and sorting sections by label threw
"Cannot read properties of undefined (reading 'localeCompare')", erroring the
whole page.

- Correct the three entries to `integrationType: "sales"` (matches each block
  config's IntegrationType.Sales and the generator's output)
- Defensively skip any integration without an integrationType when grouping so a
  single malformed catalog entry can never crash the page again
@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jun 9, 2026 12:25am

Request Review

@cursor

cursor Bot commented Jun 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI layout tweaks and catalog metadata fixes with a small defensive guard; no auth or data-path changes.

Overview
Fixes an integrations page crash by correcting three catalog entries (zerobounce, neverbounce, millionverifier) from the wrong plural field integrationTypes to integrationType, and skipping integrations without integrationType when building category sections so bad data cannot break sorting again.

Home empty state layout is adjusted so the heading and input sit at the optical center (justify-center with asymmetric vertical padding), the input column is width-capped, and suggested actions are positioned out of document flow so expanding or collapsing them no longer shifts the centered input.

Reviewed by Cursor Bugbot for commit 11e1166. Configure here.

@waleedlatif1 waleedlatif1 merged commit ffd87a3 into staging Jun 9, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/integ-page branch June 9, 2026 00:26
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes two unrelated bugs: a crash on the integrations page caused by a integrationTypes (plural) typo in three JSON entries, and a layout issue on the home page where the empty-state input was not visually centered. Both fixes are targeted and correct.

  • Integrations crash fix: Three catalog entries (zerobounce, neverbounce, millionverifier) had integrationTypes: [\"sales\"] instead of integrationType: \"sales\", which caused them to land in an undefined bucket and threw when localeCompare ran during section sorting. The JSON entries are corrected and a defensive skip guard is added in integrations.tsx.
  • Home input centering: The outer container switches to justify-center with asymmetric padding (pt-[2vh] pb-[22vh]) to optically bias the heading+input cluster above true center, and SuggestedActions is moved into an absolute inset-x-0 top-full wrapper so its expand/collapse animation no longer shifts the centered input.

Confidence Score: 5/5

Safe to merge — both changes are isolated bug fixes with no side-effects on other paths.

The JSON corrections are verified complete (zero remaining integrationTypes occurrences), the defensive guard in integrations.tsx compiles cleanly and adds resilience, and the home-page layout change is a self-contained flex/positioning adjustment whose only behavioral impact is fixing the centering and preventing layout shifts from suggestion expansion.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/lib/integrations/integrations.json Three entries (zerobounce, neverbounce, millionverifier) had the key integrationTypes (plural) corrected to integrationType — the singular key that the catalog consumes. No remaining instances of the bad key exist in the file.
apps/sim/app/workspace/[workspaceId]/integrations/integrations.tsx Defensive if (!integration.integrationType) continue guard added before grouping integrations into sections, preventing a future malformed entry from causing a localeCompare crash on sort.
apps/sim/app/workspace/[workspaceId]/home/home.tsx Optical-center layout: outer flex container switches to justify-center with asymmetric padding (pt-[2vh] pb-[22vh]) to bias the cluster above true center, and SuggestedActions is now absolutely positioned below the input so expanding/collapsing it never shifts the centered heading+input.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[integrations.json loaded as Integration array] --> B{for each integration}
    B --> C{integrationType exists?}
    C -- No, NEW GUARD --> D[skip entry]
    C -- Yes --> E[get bucket from grouped map]
    E --> F{bucket exists?}
    F -- Yes --> G[push to bucket]
    F -- No --> H[create new bucket]
    G & H --> I[sort items by name]
    I --> J[sort sections by label]
    J --> K[ALL_CATEGORY_SECTIONS rendered]

    subgraph JSON Fix
      L[integrationTypes plural typo] --> M[integrationType singular correct]
    end
    M --> A
Loading

Reviews (1): Last reviewed commit: "move home chat to optical center" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant