fix(modal): replace useEffect with render-time state reset

waleedlatif1 · waleedlatif1 · commit f6f601cfe832 · 2026-04-07T11:33:56.000-07:00
Replace useEffect anti-pattern for resetting confirmation text with
React's recommended "adjusting state during render" pattern. This
ensures stale text is never painted and avoids an extra render cycle.
diff --git a/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/delete-modal/delete-modal.tsx b/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/delete-modal/delete-modal.tsx
@@ -1,6 +1,6 @@
 'use client'
 
-import { useEffect, useState } from 'react'
+import { useState } from 'react'
 import { Button, Modal, ModalBody, ModalContent, ModalFooter, ModalHeader } from '@/components/emcn'
 
 interface DeleteModalProps {
@@ -48,12 +48,14 @@ export function DeleteModal({
   itemName,
 }: DeleteModalProps) {
   const [confirmationText, setConfirmationText] = useState('')
+  const [prevIsOpen, setPrevIsOpen] = useState(false)
 
-  useEffect(() => {
+  if (isOpen !== prevIsOpen) {
+    setPrevIsOpen(isOpen)
     if (isOpen) {
       setConfirmationText('')
     }
-  }, [isOpen])
+  }
 
   const isMultiple = Array.isArray(itemName) && itemName.length > 1
   const isSingle = !isMultiple
