fix(teams): remove smba.trafficmanager.net from Microsoft content allowlist

waleedlatif1 · waleedlatif1 · commit ee7baa50a23f · 2026-04-06T21:24:21.000-07:00
The subdomain check for smba.trafficmanager.net was unnecessary — Azure
Traffic Manager does not support nested subdomains of existing profiles,
but the pattern still raised a valid audit concern. Teams bot-framework
attachment URLs from this host fall through to the generic fetchWithDNSPinning
branch, which provides the same protection without the ambiguity.
diff --git a/apps/sim/hooks/queries/environment.ts b/apps/sim/hooks/queries/environment.ts
@@ -1,5 +1,5 @@
 import { createLogger } from '@sim/logger'
-import { keepPreviousData, useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
+import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
 import type { EnvironmentVariable, WorkspaceEnvironmentData } from '@/lib/environment/api'
 import { fetchPersonalEnvironment, fetchWorkspaceEnvironment } from '@/lib/environment/api'
 import { workspaceCredentialKeys } from '@/hooks/queries/credentials'
@@ -39,7 +39,6 @@ export function useWorkspaceEnvironment<TData = WorkspaceEnvironmentData>(
     queryFn: ({ signal }) => fetchWorkspaceEnvironment(workspaceId, signal),
     enabled: !!workspaceId,
     staleTime: 60 * 1000, // 1 minute
-    placeholderData: keepPreviousData,
     ...options,
   })
 }
diff --git a/apps/sim/lib/core/security/input-validation.ts b/apps/sim/lib/core/security/input-validation.ts
@@ -1219,7 +1219,6 @@ const MICROSOFT_CONTENT_SUFFIXES = [
   '1drv.ms',
   '1drv.com',
   'microsoftpersonalcontent.com',
-  'smba.trafficmanager.net',
 ] as const
 
 /**
@@ -1229,8 +1228,7 @@ const MICROSOFT_CONTENT_SUFFIXES = [
  *
  * Covers SharePoint Online (commercial, GCC/GCC High/DoD, Germany, China),
  * OneDrive business and consumer, OneDrive short-link and CDN domains,
- * Microsoft personal content CDN, and the Azure Traffic Manager endpoint
- * used for Teams inline image attachments.
+ * and Microsoft personal content CDN.
  *
  * @see https://learn.microsoft.com/en-us/sharepoint/required-urls-and-ports
  * @see https://learn.microsoft.com/en-us/microsoft-365/enterprise/microsoft-365-u-s-government-gcc-high-endpoints
