fix quickbooks disconnect revocation edge case

Bill Leoutsakos · Bill Leoutsakos · commit 78c0b29b3c4e · 2026-08-07T12:00:14.000-07:00
diff --git a/apps/sim/lib/oauth/quickbooks.test.ts b/apps/sim/lib/oauth/quickbooks.test.ts
@@ -66,13 +66,21 @@ describe('revokeQuickBooksToken', () => {
     await expect(result).rejects.not.toThrow('sensitive-refresh-token')
   })
 
-  it('sanitizes non-success responses', async () => {
+  it('allows local cleanup when Intuit reports an already-invalid grant', async () => {
     mockFetch.mockResolvedValueOnce(
       new Response('sensitive-refresh-token quickbooks-client-secret', { status: 400 })
     )
 
+    await expect(revokeQuickBooksToken('sensitive-refresh-token')).resolves.toBeUndefined()
+  })
+
+  it('sanitizes non-terminal non-success responses', async () => {
+    mockFetch.mockResolvedValueOnce(
+      new Response('sensitive-refresh-token quickbooks-client-secret', { status: 503 })
+    )
+
     const result = revokeQuickBooksToken('sensitive-refresh-token')
-    await expect(result).rejects.toThrow('QuickBooks token revocation failed with HTTP 400')
+    await expect(result).rejects.toThrow('QuickBooks token revocation failed with HTTP 503')
     await expect(result).rejects.not.toThrow('sensitive-refresh-token')
     await expect(result).rejects.not.toThrow('quickbooks-client-secret')
   })
diff --git a/apps/sim/lib/oauth/quickbooks.ts b/apps/sim/lib/oauth/quickbooks.ts
@@ -122,6 +122,17 @@ export async function revokeQuickBooksToken(token: string): Promise<void> {
     throw new Error('QuickBooks token revocation request failed')
   }
 
+  // Intuit returns 400 when the grant is already invalid (for example, after a
+  // user disconnects it in QuickBooks). There is no remaining remote access to
+  // revoke in that case, so local cleanup can safely continue.
+  if (response.status === 400) {
+    await readResponseTextWithLimit(response, {
+      maxBytes: QUICKBOOKS_MAX_REVOCATION_ERROR_BYTES,
+      label: 'QuickBooks token revocation response',
+    }).catch(() => {})
+    return
+  }
+
   if (!response.ok) {
     await readResponseTextWithLimit(response, {
       maxBytes: QUICKBOOKS_MAX_REVOCATION_ERROR_BYTES,
diff --git a/scripts/check-api-validation-contracts.ts b/scripts/check-api-validation-contracts.ts
@@ -9,8 +9,8 @@ const QUERY_HOOKS_DIR = path.join(ROOT, 'apps/sim/hooks/queries')
 const SELECTOR_HOOKS_DIR = path.join(ROOT, 'apps/sim/hooks/selectors')
 
 const BASELINE = {
-  totalRoutes: 1009,
-  zodRoutes: 1009,
+  totalRoutes: 1010,
+  zodRoutes: 1010,
   nonZodRoutes: 0,
 } as const
 
