fix(hubspot): address review comments

waleedlatif1 · waleedlatif1 · commit 73b42dbcb3d9 · 2026-06-13T17:26:33.000-07:00
- Forward the properties param for the Get Users operation (block param
  mapping + Properties-to-Return field now include get_users)
- Use Record&lt;string, unknown&gt; for create_note/create_email request bodies
- Only send Content-Type on create_association when a body is sent
  (default-association PUT has no body)
- Remove stray duplicate JSDoc opener in types.ts
diff --git a/apps/sim/blocks/blocks/hubspot.ts b/apps/sim/blocks/blocks/hubspot.ts
@@ -509,6 +509,7 @@ Return ONLY the JSON object with properties - no explanations, no markdown, no e
           'get_quotes',
           'get_appointments',
           'get_carts',
+          'get_users',
         ],
       },
     },
@@ -1301,6 +1302,7 @@ Return ONLY the JSON array of property names - no explanations, no markdown, no
           'get_quotes',
           'get_appointments',
           'get_carts',
+          'get_users',
         ]
         if (properties && !searchProperties && getListOps.includes(operation as string)) {
           cleanParams.properties = properties
diff --git a/apps/sim/tools/hubspot/create_association.ts b/apps/sim/tools/hubspot/create_association.ts
@@ -84,10 +84,13 @@ export const hubspotCreateAssociationTool: ToolConfig<
         throw new Error('Access token is required')
       }
 
-      return {
+      const headers: Record<string, string> = {
         Authorization: `Bearer ${params.accessToken}`,
-        'Content-Type': 'application/json',
       }
+      if (params.associationTypeId != null) {
+        headers['Content-Type'] = 'application/json'
+      }
+      return headers
     },
     body: (params) => {
       if (params.associationTypeId == null) {
diff --git a/apps/sim/tools/hubspot/create_email.ts b/apps/sim/tools/hubspot/create_email.ts
@@ -66,7 +66,7 @@ export const hubspotCreateEmailTool: ToolConfig<
         }
       }
 
-      const body: any = {
+      const body: Record<string, unknown> = {
         properties,
       }
 
diff --git a/apps/sim/tools/hubspot/create_note.ts b/apps/sim/tools/hubspot/create_note.ts
@@ -66,7 +66,7 @@ export const hubspotCreateNoteTool: ToolConfig<HubSpotCreateNoteParams, HubSpotC
           }
         }
 
-        const body: any = {
+        const body: Record<string, unknown> = {
           properties,
         }
 
diff --git a/apps/sim/tools/hubspot/types.ts b/apps/sim/tools/hubspot/types.ts
@@ -678,7 +678,6 @@ export const LISTS_ARRAY_OUTPUT: OutputProperty = {
   },
 }
 
-/**
 /**
  * Common note properties returned by HubSpot API.
  * @see https://developers.hubspot.com/docs/api-reference/crm-notes-v3

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export const hubspotCreateEmailTool: ToolConfig<`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`
`69`		`- const body: any = {`
	`69`	`+ const body: Record<string, unknown> = {`
`70`	`70`	`properties,`
`71`	`71`	`}`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -678,7 +678,6 @@ export const LISTS_ARRAY_OUTPUT: OutputProperty = {`
`678`	`678`	`},`
`679`	`679`	`}`
`680`	`680`
`681`		`-/**`
`682`	`681`	`/**`
`683`	`682`	`* Common note properties returned by HubSpot API.`
`684`	`683`	`* @see https://developers.hubspot.com/docs/api-reference/crm-notes-v3`