revert(search): return Ask Sim to prefill, storing raw prose

j15z · j15z · commit 575223d54450 · 2026-08-10T19:58:28.000-07:00
Auto-send still loses the message on cross-route navigation — use-chat's
cleanup abort fires during Home's mount-settling effect cycle. Prefill
restored, but via LandingPromptStorage directly so free-form queries are
never mentionified into @ chips.
diff --git a/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx b/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx
@@ -4,7 +4,7 @@
 import { act } from 'react'
 import { createRoot, type Root } from 'react-dom/client'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
-import { MothershipHandoffStorage } from '@/lib/core/utils/browser-storage'
+import { LandingPromptStorage } from '@/lib/core/utils/browser-storage'
 import {
   MOTHERSHIP_SEND_MESSAGE_EVENT,
   type MothershipSendMessageDetail,
@@ -163,10 +163,7 @@ describe('SearchModal', () => {
 
     expect(onOpenChange).toHaveBeenCalledWith(false)
     expect(mockPush).toHaveBeenCalledWith('/workspace/workspace-1/home')
-    expect(MothershipHandoffStorage.consume('workspace-1')).toEqual({
-      message: 'plan our Slack launch week',
-      contexts: [],
-    })
+    expect(LandingPromptStorage.consume()).toBe('plan our Slack launch week')
   })
 
   it('returns to search results when Tab is pressed again in ask mode', async () => {
@@ -298,7 +295,7 @@ describe('SearchModal', () => {
 
       expect(receivedMessages).toEqual(['summarize this workspace'])
       expect(mockPush).not.toHaveBeenCalled()
-      expect(MothershipHandoffStorage.consume('workspace-1')).toBeNull()
+      expect(LandingPromptStorage.consume()).toBeNull()
     } finally {
       window.removeEventListener(MOTHERSHIP_SEND_MESSAGE_EVENT, handleMessage)
     }
@@ -694,7 +691,7 @@ describe('SearchModal', () => {
 
   it('keeps the palette open when the query handoff cannot be persisted', async () => {
     const onOpenChange = vi.fn()
-    const storeSpy = vi.spyOn(MothershipHandoffStorage, 'store').mockReturnValue(false)
+    const storeSpy = vi.spyOn(LandingPromptStorage, 'store').mockReturnValue(false)
 
     try {
       await act(async () => {
diff --git a/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx b/apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx
@@ -41,7 +41,7 @@ import { usePostHog } from 'posthog-js/react'
 import { createPortal } from 'react-dom'
 import { supportsAtomicBrowserPanelOcclusion } from '@/lib/browser-agent/transport'
 import { isChatEnabled } from '@/lib/core/config/env-flags'
-import { MothershipHandoffStorage } from '@/lib/core/utils/browser-storage'
+import { LandingPromptStorage } from '@/lib/core/utils/browser-storage'
 import { sendMothershipMessage } from '@/lib/mothership/events'
 import { captureEvent } from '@/lib/posthog/client'
 import { toSearchToken } from '@/lib/search/tokens'
@@ -844,12 +844,11 @@ function SearchModalContent({
     const sentToMountedHome = window.location.pathname === homeHref && sendMothershipMessage(query)
 
     if (!sentToMountedHome) {
-      /* One-shot auto-send handoff: Home's mount consumer sends it on arrival,
-         so both routes deliver the raw query identically. use-chat's queued
-         send dispatch now survives the mount-settling effect cycle that used
-         to silently abort programmatic sends (the old reason this was a
-         prefill). */
-      if (!MothershipHandoffStorage.store({ message: query }, workspaceId)) {
+      /* Prefill, not auto-send: sends started during Home's mount-settling
+         window are still silently aborted by use-chat's cleanup effect, so a
+         MothershipHandoffStorage handoff would vanish (verified live). Stored
+         raw — user prose is never mentionified into @ chips. */
+      if (!LandingPromptStorage.store(query)) {
         logger.warn('Failed to persist command palette query for a new chat', {
           workspaceId,
         })
