fix(security): redact nested credential references

TheodoreSpeaks · TheodoreSpeaks · commit 56ab7d0b9ef5 · 2026-08-11T19:42:41.000-07:00
diff --git a/apps/sim/lib/workflows/credentials/credential-extractor.test.ts b/apps/sim/lib/workflows/credentials/credential-extractor.test.ts
@@ -25,6 +25,7 @@ vi.mock('@/lib/workflows/search-replace/indexer', () => ({
         id: paramId,
         type: 'short-input',
         password: paramId === 'apiKey' || paramId === 'token',
+        canonicalParamId: paramId === 'manualCredential' ? 'oauthCredential' : undefined,
       },
     })),
 }))
@@ -147,6 +148,40 @@ describe('export sanitizer resource coverage', () => {
     ])
   })
 
+  it('withholds advanced credential selectors nested inside tool inputs', () => {
+    const value = [
+      {
+        type: 'gmail',
+        toolId: 'gmail_send',
+        operation: 'send_gmail',
+        params: {
+          manualCredential: 'credential-id',
+          query: 'safe input',
+        },
+      },
+    ]
+    vi.mocked(getBlock).mockReturnValue({
+      name: 'Test',
+      description: '',
+      subBlocks: [{ id: 'field', title: 'Field', type: 'tool-input' }],
+      outputs: {},
+    } as never)
+
+    const sanitized = sanitizeWorkflowForSharing(stateWithSubBlock('tool-input', value), {
+      preserveEnvVars: true,
+      redactOpaqueCredentialInputs: true,
+    })
+
+    expect(sanitized.blocks?.b1?.subBlocks?.field?.value).toEqual([
+      {
+        type: 'gmail',
+        toolId: 'gmail_send',
+        operation: 'send_gmail',
+        params: { manualCredential: null, query: 'safe input' },
+      },
+    ])
+  })
+
   it('withholds opaque table values from public snapshots', () => {
     const value = [
       { Key: 'Authorization', Value: 'Bearer plaintext-secret' },
diff --git a/apps/sim/lib/workflows/credentials/credential-extractor.ts b/apps/sim/lib/workflows/credentials/credential-extractor.ts
@@ -70,6 +70,8 @@ const WORKSPACE_SPECIFIC_TYPES: ReadonlySet<string> = new Set<string>([
  * type-keyed registry above cannot supply, so this list stays explicit.
  */
 const WORKSPACE_SPECIFIC_FIELDS = new Set([
+  'credentialId',
+  'oauthCredential',
   'knowledgeBaseId',
   'tagFilters',
   'documentTags',
@@ -339,7 +341,11 @@ function sanitizeConfiguredSubBlockValue(
   if (config.password === true) {
     return options.preserveEnvVars && isEnvironmentVariableReference(value) ? value : null
   }
-  if (WORKSPACE_SPECIFIC_TYPES.has(config.type) || WORKSPACE_SPECIFIC_FIELDS.has(config.id)) {
+  if (
+    WORKSPACE_SPECIFIC_TYPES.has(config.type) ||
+    WORKSPACE_SPECIFIC_FIELDS.has(config.id) ||
+    (config.canonicalParamId != null && WORKSPACE_SPECIFIC_FIELDS.has(config.canonicalParamId))
+  ) {
     return null
   }
   return value
