address comments

icecrasher321 · icecrasher321 · commit 33aa581351d2 · 2026-04-03T15:42:45.000-07:00
diff --git a/apps/sim/executor/execution/engine.test.ts b/apps/sim/executor/execution/engine.test.ts
@@ -1067,7 +1067,7 @@ describe('ExecutionEngine', () => {
             return {
               nodeId,
               output: { data: { fast: true }, status: 200, headers: {} },
-              isFinalOutput: false,
+              isFinalOutput: true,
             }
           }
           if (nodeId === 'slow-work') {
@@ -1204,6 +1204,48 @@ describe('ExecutionEngine', () => {
       expect(result.success).toBe(true)
       expect(result.output).toEqual({ data: { response: true }, status: 200, headers: {} })
     })
+
+    it('should honor locked Response output even when a parallel node throws an error', async () => {
+      const startNode = createMockNode('start', 'starter')
+      const responseNode = createMockNode('response', 'response')
+      const errorNode = createMockNode('error-node', 'function')
+
+      startNode.outgoingEdges.set('edge1', { target: 'response' })
+      startNode.outgoingEdges.set('edge2', { target: 'error-node' })
+
+      const dag = createMockDAG([startNode, responseNode, errorNode])
+      const context = createMockContext()
+      const edgeManager = createMockEdgeManager((node) => {
+        if (node.id === 'start') return ['response', 'error-node']
+        return []
+      })
+
+      const nodeOrchestrator = {
+        executionCount: 0,
+        executeNode: vi.fn().mockImplementation(async (_ctx: ExecutionContext, nodeId: string) => {
+          nodeOrchestrator.executionCount++
+          if (nodeId === 'response') {
+            return {
+              nodeId,
+              output: { data: { ok: true }, status: 200, headers: {} },
+              isFinalOutput: true,
+            }
+          }
+          if (nodeId === 'error-node') {
+            await new Promise((resolve) => setTimeout(resolve, 1))
+            throw new Error('Parallel branch failed')
+          }
+          return { nodeId, output: {}, isFinalOutput: false }
+        }),
+        handleNodeCompletion: vi.fn(),
+      } as unknown as MockNodeOrchestrator
+
+      const engine = new ExecutionEngine(context, dag, edgeManager, nodeOrchestrator)
+      const result = await engine.run('start')
+
+      expect(result.success).toBe(true)
+      expect(result.output).toEqual({ data: { ok: true }, status: 200, headers: {} })
+    })
   })
 
   describe('Cancellation flag behavior', () => {
diff --git a/apps/sim/executor/execution/engine.ts b/apps/sim/executor/execution/engine.ts
@@ -128,8 +128,7 @@ export class ExecutionEngine {
         await this.waitForAllExecutions()
       }
 
-      // Rethrow the captured error so it's handled by the catch block
-      if (this.errorFlag && this.executionError) {
+      if (this.errorFlag && this.executionError && !this.responseOutputLocked) {
         throw this.executionError
       }
 
@@ -401,6 +400,8 @@ export class ExecutionEngine {
     }
 
     if (this.stoppedEarlyFlag && this.responseOutputLocked) {
+      // Workflow already ended via Response block. Skip state persistence (setBlockOutput),
+      // parallel/loop scope tracking, and edge propagation — no downstream blocks will run.
       return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,7 @@ export class ExecutionEngine {`
`128`	`128`	`await this.waitForAllExecutions()`
`129`	`129`	`}`
`130`	`130`
`131`		`- // Rethrow the captured error so it's handled by the catch block`
`132`		`- if (this.errorFlag && this.executionError) {`
	`131`	`+ if (this.errorFlag && this.executionError && !this.responseOutputLocked) {`
`133`	`132`	`throw this.executionError`
`134`	`133`	`}`
`135`	`134`
`@@ -401,6 +400,8 @@ export class ExecutionEngine {`
`401`	`400`	`}`
`402`	`401`
`403`	`402`	`if (this.stoppedEarlyFlag && this.responseOutputLocked) {`
	`403`	`+ // Workflow already ended via Response block. Skip state persistence (setBlockOutput),`
	`404`	`+ // parallel/loop scope tracking, and edge propagation — no downstream blocks will run.`
`404`	`405`	`return`
`405`	`406`	`}`
`406`	`407`