Bugfix: use the correct DOMElement to create the object

tvdijen · tvdijen · commit ed04b7dd0988 · 2024-09-13T16:16:31.000+02:00
diff --git a/src/ExtendableElementTrait.php b/src/ExtendableElementTrait.php
@@ -68,7 +68,7 @@ protected static function getChildElementsFromXML(DOMElement $xml, NS|array $nam
                 }
 
                 $handler = $registry->getElementHandler($elt->namespaceURI, $elt->localName);
-                $elements[] = ($handler === null) ? Chunk::fromXML($xml) : $handler::fromXML($xml);
+                $elements[] = ($handler === null) ? Chunk::fromXML($elt) : $handler::fromXML($elt);
             }
         } else {
             // Array must be non-empty and cannot contain ##any or ##other
@@ -97,7 +97,7 @@ protected static function getChildElementsFromXML(DOMElement $xml, NS|array $nam
                 }
 
                 $handler = $registry->getElementHandler($elt->namespaceURI, $elt->localName);
-                $elements[] = ($handler === null) ? Chunk::fromXML($xml) : $handler::fromXML($xml);
+                $elements[] = ($handler === null) ? Chunk::fromXML($elt) : $handler::fromXML($elt);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ protected static function getChildElementsFromXML(DOMElement $xml, NS\|array $nam`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`$handler = $registry->getElementHandler($elt->namespaceURI, $elt->localName);`
`71`		`- $elements[] = ($handler === null) ? Chunk::fromXML($xml) : $handler::fromXML($xml);`
	`71`	`+ $elements[] = ($handler === null) ? Chunk::fromXML($elt) : $handler::fromXML($elt);`
`72`	`72`	`}`
`73`	`73`	`} else {`
`74`	`74`	`// Array must be non-empty and cannot contain ##any or ##other`
`@@ -97,7 +97,7 @@ protected static function getChildElementsFromXML(DOMElement $xml, NS\|array $nam`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`$handler = $registry->getElementHandler($elt->namespaceURI, $elt->localName);`
`100`		`- $elements[] = ($handler === null) ? Chunk::fromXML($xml) : $handler::fromXML($xml);`
	`100`	`+ $elements[] = ($handler === null) ? Chunk::fromXML($elt) : $handler::fromXML($elt);`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`