From 1a49537547c2da7dd371fb29f3d4da7c15e3596b Mon Sep 17 00:00:00 2001 From: Tim van Dijen Date: Tue, 10 Mar 2026 21:27:08 +0100 Subject: [PATCH 01/10] Use local version of phplint --- .github/workflows/reusable_phplinter.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/reusable_phplinter.yml b/.github/workflows/reusable_phplinter.yml index c7ce48c..26dc90b 100644 --- a/.github/workflows/reusable_phplinter.yml +++ b/.github/workflows/reusable_phplinter.yml @@ -43,13 +43,12 @@ jobs: tools: phive php-version: ${{ inputs.php-version }} coverage: "none" + tools: composer + # A conflict exists between overtrue/phplint and redis extensions: :redis - name: Install overtrue/phplint (v9.7) - run: | - sleep $((random % 10)) - phive install overtrue/phplint@~9.7.1 --force-accept-unsigned --target ./bin + run: composer require overtrue/phplint - name: Lint PHP files - run: | - ./bin/phplint --no-cache --no-progress -v + run: vendor/bin/phplint --no-cache --no-progress -v From e049a2251a372acad562f8b41f1cb9e440c2f031 Mon Sep 17 00:00:00 2001 From: Tim van Dijen Date: Sat, 14 Mar 2026 12:23:12 +0100 Subject: [PATCH 02/10] Revert change to ArrayLogger --- src/ArrayLogger.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/ArrayLogger.php b/src/ArrayLogger.php index 421df60..297e65b 100644 --- a/src/ArrayLogger.php +++ b/src/ArrayLogger.php @@ -7,8 +7,6 @@ use SimpleSAML\Configuration; use SimpleSAML\Logger\LoggingHandlerInterface; -use function array_merge; - /** */ class ArrayLogger implements LoggingHandlerInterface @@ -28,7 +26,7 @@ public function __construct(Configuration $config) public function log(int $level, string $str): void { - $this->logs[$level] = array_merge($this->logs[$level], [$str]); + $this->logs[$level][] = $str; } From bde8ac9931203ac4c5aff32102d6c91716229cf1 Mon Sep 17 00:00:00 2001 From: Tim van Dijen Date: Sat, 14 Mar 2026 12:24:26 +0100 Subject: [PATCH 03/10] Fix linter-workflow --- .github/workflows/reusable_phplinter.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/reusable_phplinter.yml b/.github/workflows/reusable_phplinter.yml index 26dc90b..e5f5c52 100644 --- a/.github/workflows/reusable_phplinter.yml +++ b/.github/workflows/reusable_phplinter.yml @@ -40,10 +40,9 @@ jobs: - name: Setup PHP runtime uses: shivammathur/setup-php@v2 with: - tools: phive + tools: composer, phive php-version: ${{ inputs.php-version }} coverage: "none" - tools: composer # A conflict exists between overtrue/phplint and redis extensions: :redis From ae5875aba69a159df0fdfaf8491201b0c1cf73e1 Mon Sep 17 00:00:00 2001 From: Tim van Dijen Date: Sat, 14 Mar 2026 12:29:20 +0100 Subject: [PATCH 04/10] Fix composer-cache --- .github/workflows/php.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index 5f82b6f..d4f17a0 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -77,7 +77,7 @@ jobs: - name: Cache composer dependencies uses: actions/cache@v5 with: - path: $COMPOSER_CACHE + path: ${{ env.COMPOSER_CACHE }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- @@ -140,7 +140,7 @@ jobs: - name: Cache composer dependencies uses: actions/cache@v5 with: - path: $COMPOSER_CACHE + path: ${{ env.COMPOSER_CACHE }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- @@ -177,7 +177,7 @@ jobs: - name: Cache composer dependencies uses: actions/cache@v5 with: - path: $COMPOSER_CACHE + path: ${{ env.COMPOSER_CACHE }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- @@ -241,7 +241,7 @@ jobs: - name: Cache composer dependencies uses: actions/cache@v5 with: - path: $COMPOSER_CACHE + path: ${{ env.COMPOSER_CACHE }} key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} restore-keys: ${{ runner.os }}-composer- From 47f5bed855ba48b06cc5c467f6a43aa777c985e9 Mon Sep 17 00:00:00 2001 From: Tim van Dijen Date: Sat, 14 Mar 2026 12:37:16 +0100 Subject: [PATCH 05/10] Delete 1 --- 1 | 35 ----------------------------------- 1 file changed, 35 deletions(-) delete mode 100644 1 diff --git a/1 b/1 deleted file mode 100644 index f13d063..0000000 --- a/1 +++ /dev/null @@ -1,35 +0,0 @@ -pick a6e6d49 Add support for PHPunit 13 -pick e0061f5 Move contents of lib-dir to src-dir -pick 61fddec Fix CI -s 08712a5 Fix CI - -# Rebase 720ccf7..08712a5 onto 720ccf7 (4 commands) -# -# Commands: -# p, pick = use commit -# r, reword = use commit, but edit the commit message -# e, edit = use commit, but stop for amending -# s, squash = use commit, but meld into previous commit -# f, fixup [-C | -c] = like "squash" but keep only the previous -# commit's log message, unless -C is used, in which case -# keep only this commit's message; -c is same as -C but -# opens the editor -# x, exec = run command (the rest of the line) using shell -# b, break = stop here (continue rebase later with 'git rebase --continue') -# d, drop = remove commit -# l, label