Codecov Report

Merging #1901 (74d478c) into master (d456913) will decrease coverage by 0.49%.
Report is 3 commits behind head on master.
The diff coverage is 52.95%.

@@             Coverage Diff              @@
##             master    #1901      +/-   ##
============================================
- Coverage     44.59%   44.10%   -0.49%     
+ Complexity     3743     3720      -23     
============================================
  Files           166      165       -1     
  Lines         12728    12728              
============================================
- Hits           5676     5614      -62     
- Misses         7052     7114      +62     

I noticed a few things on the first reading. One which is probably a matter of style is the old getEntityDescriptorText method being removed seems to want replication of the following lines in places that used to call that.

            $entityDescriptor = $builder->buildDocument();
            $document = $entityDescriptor->toXML();
            $document->ownerDocument->formatOutput = true;
            $document->ownerDocument->encoding = 'UTF-8';
            $xml = $document->ownerDocument->saveXML();

If the document is not used for other purposes than builder to XML string then maybe having a buildXMLString() in MetadataBuilder?

            $xml = $builder->buildXMLString();

Yes, I believe these lines are replicated one or two times, so it makes sense to refactor this into a new method!

I have been working on a MetadataParser implementation. It is sort of a copy from SAMLParser and attempt to update the code so a copy of SAMLParserTest copied to MetadataParserTest will actually run. It is a bit slow going at the moment.

I am trying to get DiscoveryResponse to be processed properly for the first test to actually complete :/

Make sure to leverage the toArray-method on some of the saml2-elements. We can add more if needed

I should have the other 9 tests working today or very soon. The code is still extremely ugly, my first goal was getting the existing tests to all work on MetadataParser and then move on from there.

I pushed the starting changes up here as it was a new class and an update to the one test file. As I have point on this update I thought that wasn't going to get in the way of anything being partial.

My starting plan was to create MetadataParser as a copy of SAMLParser and update it to the new SimpleSAML\SAML2\XML\md classes. Then I would try to get the tests in MetadataParserTest.php to all run again. That is the place I am at currently. [ed: the 10 tests now run]

The code in MetadataParser is very rough and not "merge ready" but does what is needed for that test suite file to run and be happy. From there working out how to merge the changes inisHiddenFromDiscoveryAV into isHiddenFromDiscovery so there are not two methods and substituting out the self::flatten method for something more descriptive or correct. Then making the MetadataParser class more of a first class citizen (fully update the code and remove redundant stuff) while still running the test suite ok is the goal.