Fix RequestedAuthnContextSelector for case with multiple RACs in request

tvdijen · tvdijen · commit f1a2e81d3067 · 2024-04-09T12:14:59.000+02:00
diff --git a/modules/core/src/Auth/Source/RequestedAuthnContextSelector.php b/modules/core/src/Auth/Source/RequestedAuthnContextSelector.php
@@ -142,7 +142,7 @@ protected function selectAuthSource(array &$state): string
                             return $context['source'];
                         }
                     }
-                    break 2;
+                    break 1;
                 case 'minimum':
                 case 'maximum':
                 case 'better':
diff --git a/tests/modules/core/src/Auth/Source/RequestedAuthnContextSelectorTest.php b/tests/modules/core/src/Auth/Source/RequestedAuthnContextSelectorTest.php
@@ -356,6 +356,18 @@ public static function provideRequestedAuthnContext(): array
                 ],
                 'loa2',
             ],
+            [
+                [
+                    'AuthnContextClassRef' => [
+                        'urn:x-simplesamlphp:loa30',
+                        'urn:x-simplesamlphp:loa20',
+                        'urn:x-simplesamlphp:loa2',
+                        'urn:x-simplesamlphp:loa10',
+                    ],
+                    'Comparison' => 'exact',
+                ],
+                'loa2',
+            ],
 
             // Unknown context requested
             [

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ protected function selectAuthSource(array &$state): string`
`142`	`142`	`return $context['source'];`
`143`	`143`	`}`
`144`	`144`	`}`
`145`		`- break 2;`
	`145`	`+ break 1;`
`146`	`146`	`case 'minimum':`
`147`	`147`	`case 'maximum':`
`148`	`148`	`case 'better':`