Tone down the error level of missing locale dirs

thijskh · thijskh · commit db997a7e8f64 · 2023-01-30T16:57:10.000+01:00
It is quite fine if e.g. a theme does not have its own locales dir.
The exception is already caught, so the application does not actually
stop. So, notice it but do not raise high alarms.
diff --git a/src/SimpleSAML/Locale/Localization.php b/src/SimpleSAML/Locale/Localization.php
@@ -200,13 +200,13 @@ public function getLangPath(string $domain = self::DEFAULT_DOMAIN): string
             // Report that the localization for the preferred language is missing
             $error = "Localization not found for langcode '$langcode' at '$langPath', falling back to langcode '" .
                 $defLangcode . "'";
-            Logger::error($_SERVER['PHP_SELF'] . ' - ' . $error);
+            Logger::info($_SERVER['PHP_SELF'] . ' - ' . $error);
             return $langPath;
         }
 
         // Locale for default language missing even, error out
         $error = "Localization directory '$langPath' missing/broken for langcode '$langcode' and domain '$domain'";
-        Logger::critical($_SERVER['PHP_SELF'] . ' - ' . $error);
+        Logger::info($_SERVER['PHP_SELF'] . ' - ' . $error);
         throw new Exception($error);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -200,13 +200,13 @@ public function getLangPath(string $domain = self::DEFAULT_DOMAIN): string`
`200`	`200`	`// Report that the localization for the preferred language is missing`
`201`	`201`	`$error = "Localization not found for langcode '$langcode' at '$langPath', falling back to langcode '" .`
`202`	`202`	`$defLangcode . "'";`
`203`		`- Logger::error($_SERVER['PHP_SELF'] . ' - ' . $error);`
	`203`	`+ Logger::info($_SERVER['PHP_SELF'] . ' - ' . $error);`
`204`	`204`	`return $langPath;`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`// Locale for default language missing even, error out`
`208`	`208`	`$error = "Localization directory '$langPath' missing/broken for langcode '$langcode' and domain '$domain'";`
`209`		`- Logger::critical($_SERVER['PHP_SELF'] . ' - ' . $error);`
	`209`	`+ Logger::info($_SERVER['PHP_SELF'] . ' - ' . $error);`
`210`	`210`	`throw new Exception($error);`
`211`	`211`	`}`
`212`	`212`