Fix comparison

tvdijen · tvdijen · commit ad474ddbbb8a · 2025-08-21T00:28:40.000+02:00
diff --git a/modules/saml/src/Message.php b/modules/saml/src/Message.php
@@ -24,6 +24,7 @@
 use SimpleSAML\Logger;
 use SimpleSAML\Module\saml\Error as SAMLError;
 use SimpleSAML\SAML2\Constants;
+use SimpleSAML\SAML2\XML\Comparison;
 use SimpleSAML\Utils;
 
 /**
@@ -505,12 +506,11 @@ public static function buildAuthnRequest(
 
         if ($spMetadata->hasValue('AuthnContextClassRef')) {
             $accr = $spMetadata->getArrayizeString('AuthnContextClassRef');
-            $comp = $spMetadata->getOptionalValueValidate('AuthnContextComparison', [
-                Constants::COMPARISON_EXACT,
-                Constants::COMPARISON_MINIMUM,
-                Constants::COMPARISON_MAXIMUM,
-                Constants::COMPARISON_BETTER,
-            ], Constants::COMPARISON_EXACT);
+            $comp = $spMetadata->getOptionalValueValidate(
+                'AuthnContextComparison',
+                array_column(Comparison::cases(), 'value'),
+                Comparison::EXACT->value,
+            );
             $ar->setRequestedAuthnContext(['AuthnContextClassRef' => $accr, 'Comparison' => $comp]);
         }
 
