Fix metadata generation for indexed endpoints with isDefault set (#2439)

tvdijen · tvdijen · commit 9543a32e9d83 · 2025-05-21T10:09:46.000+02:00
* Fix metadata generation for indexed endpoints with isDefault set

* Add note to docs
diff --git a/docs/simplesamlphp-changelog.md b/docs/simplesamlphp-changelog.md
@@ -9,6 +9,7 @@ See the [upgrade notes](https://simplesamlphp.org/docs/stable/simplesamlphp-upgr
 
 Released TBD
 
+* Fixed a bug where metadata-endpoints with isDefault set would not yield the expected metadata (#2439)
 * Downgrade simplesamlphp/composer-module-installer to 1.3.x to keep things working with older (OS-supplied)
   versions of composer
 * Fixed one more PHP 8.4 deprecation notice
diff --git a/docs/simplesamlphp-metadata-endpoints.md b/docs/simplesamlphp-metadata-endpoints.md
@@ -12,6 +12,8 @@ Endpoint                       | Indexed | Default binding
 `SingleLogoutService`          | N       | HTTP-Redirect
 `SingleSignOnService`          | N       | HTTP-Redirect
 
+Note that `isDefault` is only available for indexed endpoints.
+
 The various endpoints can be specified in the following format:
 
     'AssertionConsumerService' => [
diff --git a/src/SimpleSAML/Metadata/SAMLBuilder.php b/src/SimpleSAML/Metadata/SAMLBuilder.php
@@ -347,6 +347,11 @@ private static function createEndpoints(array $endpoints, bool $indexed): array
         foreach ($endpoints as &$ep) {
             if ($indexed) {
                 $t = new IndexedEndpointType();
+
+                if (isset($ep['isDefault'])) {
+                    $t->setIsDefault($ep['isDefault']);
+                }
+
                 if (!isset($ep['index'])) {
                     // Find the maximum index
                     $maxIndex = -1;
