Test reponse-results

tvdijen · tvdijen · commit 69f0cac8aab8 · 2023-02-13T21:38:35.000+01:00
diff --git a/tests/modules/admin/src/Controller/SandboxTest.php b/tests/modules/admin/src/Controller/SandboxTest.php
@@ -52,5 +52,6 @@ public function testSandbox(): void
         $response = $c->main();
 
         $this->assertInstanceOf(Template::class, $response);
+        $this->assertTrue($response->isSuccessful());
     }
 }
diff --git a/tests/modules/core/src/Controller/ErrorReportTest.php b/tests/modules/core/src/Controller/ErrorReportTest.php
@@ -65,6 +65,7 @@ public function testErrorReportSent(): void
         $response = $c->main($request);
 
         $this->assertInstanceOf(Template::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $this->assertEquals('core:errorreport.twig', $response->getTemplateName());
     }
 
@@ -109,5 +110,6 @@ public function testErrorReport(): void
         $response = $c->main($request);
 
         $this->assertInstanceOf(RunnableResponse::class, $response);
+        $this->assertTrue($response->isSuccessful());
     }
 }
diff --git a/tests/modules/core/src/Controller/LoginTest.php b/tests/modules/core/src/Controller/LoginTest.php
@@ -67,6 +67,7 @@ public function testWelcome(): void
         $response = $c->welcome();
 
         $this->assertInstanceOf(Template::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $this->assertEquals('core:welcome.twig', $response->getTemplateName());
     }
 
@@ -135,6 +136,7 @@ protected function login(string $username, string $password): array
         $response = $c->loginuserpass($request);
 
         $this->assertInstanceOf(Template::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $this->assertEquals('core:loginuserpass.twig', $response->getTemplateName());
     }
 
@@ -205,6 +207,7 @@ protected function getOrganizations(): array
         $response = $c->loginuserpassorg($request);
 
         $this->assertInstanceOf(Template::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $this->assertEquals('core:loginuserpass.twig', $response->getTemplateName());
     }
      */
diff --git a/tests/modules/core/src/Controller/LogoutTest.php b/tests/modules/core/src/Controller/LogoutTest.php
@@ -65,6 +65,7 @@ public function testLogout(): void
         $response = $c->logout($request, 'example-authsource');
 
         $this->assertInstanceOf(RunnableResponse::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $callable = $response->getCallable();
         $this->assertInstanceOf(Auth\Simple::class, $callable[0]);
         $this->assertEquals('logout', $callable[1]);
@@ -101,6 +102,7 @@ public function testLogoutReturnToAllowedUrl(): void
 
         $response = $c->logout($request, 'example-authsource');
         $this->assertInstanceOf(RunnableResponse::class, $response);
+        $this->assertTrue($response->isSuccessful());
         $this->assertEquals('https://example.org/something', $response->getArguments()[0]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -52,5 +52,6 @@ public function testSandbox(): void`
`52`	`52`	`$response = $c->main();`
`53`	`53`
`54`	`54`	`$this->assertInstanceOf(Template::class, $response);`
	`55`	`+ $this->assertTrue($response->isSuccessful());`
`55`	`56`	`}`
`56`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ public function testErrorReportSent(): void`
`65`	`65`	`$response = $c->main($request);`
`66`	`66`
`67`	`67`	`$this->assertInstanceOf(Template::class, $response);`
	`68`	`+ $this->assertTrue($response->isSuccessful());`
`68`	`69`	`$this->assertEquals('core:errorreport.twig', $response->getTemplateName());`
`69`	`70`	`}`
`70`	`71`
`@@ -109,5 +110,6 @@ public function testErrorReport(): void`
`109`	`110`	`$response = $c->main($request);`
`110`	`111`
`111`	`112`	`$this->assertInstanceOf(RunnableResponse::class, $response);`
	`113`	`+ $this->assertTrue($response->isSuccessful());`
`112`	`114`	`}`
`113`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ public function testWelcome(): void`
`67`	`67`	`$response = $c->welcome();`
`68`	`68`
`69`	`69`	`$this->assertInstanceOf(Template::class, $response);`
	`70`	`+ $this->assertTrue($response->isSuccessful());`
`70`	`71`	`$this->assertEquals('core:welcome.twig', $response->getTemplateName());`
`71`	`72`	`}`
`72`	`73`
`@@ -135,6 +136,7 @@ protected function login(string $username, string $password): array`
`135`	`136`	`$response = $c->loginuserpass($request);`
`136`	`137`
`137`	`138`	`$this->assertInstanceOf(Template::class, $response);`
	`139`	`+ $this->assertTrue($response->isSuccessful());`
`138`	`140`	`$this->assertEquals('core:loginuserpass.twig', $response->getTemplateName());`
`139`	`141`	`}`
`140`	`142`
`@@ -205,6 +207,7 @@ protected function getOrganizations(): array`
`205`	`207`	`$response = $c->loginuserpassorg($request);`
`206`	`208`
`207`	`209`	`$this->assertInstanceOf(Template::class, $response);`
	`210`	`+ $this->assertTrue($response->isSuccessful());`
`208`	`211`	`$this->assertEquals('core:loginuserpass.twig', $response->getTemplateName());`
`209`	`212`	`}`
`210`	`213`	`*/`