log unserialize failures with descriptive message

monkeyiq · monkeyiq · commit 34c082ae12c6 · 2024-05-12T10:30:09.000+10:00
diff --git a/src/SimpleSAML/SessionHandlerPHP.php b/src/SimpleSAML/SessionHandlerPHP.php
@@ -265,6 +265,10 @@ public function loadSession(string $sessionId = null): ?Session
         try {
             $session = unserialize($session);
         } catch (\Throwable $e) {
+            Logger::warning('Session load failed using unserialize().'
+                         .  'If you have just upgraded this might be ok. '
+                          . 'If not there might be an issue with your storage. '
+                          . $e->getMessage());
             $session = null;  # sometimes deserializing fails, so we throw it away
         }
         return ($session !== false) ? $session : null;
