bugfix: use of undefined variable

tvdijen · tvdijen · commit 2bf88751882e · 2018-08-22T21:36:30.000+02:00
diff --git a/lib/SimpleSAML/IdP/IFrameLogoutHandler.php b/lib/SimpleSAML/IdP/IFrameLogoutHandler.php
@@ -95,7 +95,9 @@ public function onResponse($assocId, $relayState, \SimpleSAML\Error\Exception $e
         $t = new \SimpleSAML\XHTML\Template($config, 'IFrameLogoutHandler.twig');
         $t->data['assocId'] = var_export($assocId, true);
         $t->data['spId'] = sha1($assocId);
-        $t->data['errorMsg'] = $error->getMessage();
+        if (!is_null($error)) {
+            $t->data['errorMsg'] = $error->getMessage();
+        }
         $t->show();
         exit(0);
     }
diff --git a/templates/IFrameLogoutHandler.twig b/templates/IFrameLogoutHandler.twig
@@ -3,7 +3,7 @@
     <head>
         <title>Logout response from {{ assocId|escape('html') }}</title>
         <script>
-{% if error %}
+{% if errorMsg is defined %}
             window.parent.logoutFailed("{{ spId }}", "{{ errorMsg|escape }}");
 {% else %}
             window.parent.logoutCompleted("{{ spId }}");
