Let tests use actually valid state ids

thijskh · thijskh · commit 261e36f5b780 · 2023-03-01T14:37:00.000+01:00
diff --git a/tests/modules/core/src/Controller/LoginTest.php b/tests/modules/core/src/Controller/LoginTest.php
@@ -99,7 +99,7 @@ public function testLoginUserPass(): void
         $request = Request::create(
             '/loginuserpass',
             'GET',
-            ['AuthState' => 'someState'],
+            ['AuthState' => '_abc123'],
         );
 
         $c = new Controller\Login($this->config);
@@ -165,7 +165,7 @@ public function testLoginUserPassOrg(): void
         $request = Request::create(
             '/loginuserpassorg',
             'GET',
-            ['AuthState' => 'someState'],
+            ['AuthState' => '_abc123'],
         );
 
         $c = new Controller\Login($this->config);
diff --git a/tests/modules/core/src/Controller/LogoutTest.php b/tests/modules/core/src/Controller/LogoutTest.php
@@ -113,7 +113,7 @@ public function testLogoutIframeDoneUnknownEntityThrowsException(): void
         $request = Request::create(
             '/logout-iframe-done',
             'GET',
-            ['id' => 'someState'],
+            ['id' => '_abc123'],
         );
 
         $c = new Controller\Logout($this->config);
@@ -134,7 +134,7 @@ public function testLogoutIframeDoneWithoutStateThrowsException(): void
         $request = Request::create(
             '/logout-iframe-done',
             'GET',
-            ['id' => 'someState'],
+            ['id' => '_abc123'],
         );
 
         $c = new Controller\Logout($this->config);
diff --git a/tests/modules/exampleauth/src/Controller/ExampleAuthTest.php b/tests/modules/exampleauth/src/Controller/ExampleAuthTest.php
@@ -207,7 +207,7 @@ public function testRedirect(): void
         $request = Request::create(
             '/redirecttest',
             'GET',
-            ['StateId' => 'someState']
+            ['StateId' => '_abc123']
         );
 
         $c = new Controller\ExampleAuth($this->config, $this->session);
diff --git a/tests/modules/multiauth/src/Controller/DiscoControllerTest.php b/tests/modules/multiauth/src/Controller/DiscoControllerTest.php
@@ -101,7 +101,7 @@ public function testDiscoveryFallthru(): void
         $request = Request::create(
             '/discovery',
             'GET',
-            ['AuthState' => 'someState']
+            ['AuthState' => '_abc123']
         );
 
         $c = new Controller\DiscoController($this->config, $this->session);
@@ -154,7 +154,7 @@ public function testDiscoveryFallthruWithSource(): void
         $request = Request::create(
             '/discovery',
             'GET',
-            ['AuthState' => 'someState']
+            ['AuthState' => '_abc123']
         );
 
         $c = new Controller\DiscoController($this->config, $this->session);
@@ -208,7 +208,7 @@ public function testDiscoveryDelegateAuth1(): void
         $request = Request::create(
             '/discovery',
             'GET',
-            ['AuthState' => 'someState']
+            ['AuthState' => '_abc123']
         );
 
         $c = new Controller\DiscoController($this->config, $this->session);
@@ -264,7 +264,7 @@ public function testDiscoveryDelegateAuth1WithPreviousSource(): void
         $request = Request::create(
             '/discovery',
             'GET',
-            ['AuthState' => 'someState', 'source' => 'admin']
+            ['AuthState' => '_abc123', 'source' => 'admin']
         );
 
         $c = new Controller\DiscoController($this->config, $this->session);
@@ -320,7 +320,7 @@ public function testDiscoveryDelegateAuth2(): void
         $request = Request::create(
             '/discovery',
             'GET',
-            ['AuthState' => 'someState', 'sourceChoice[admin]' => 'something admin']
+            ['AuthState' => '_abc123', 'sourceChoice[admin]' => 'something admin']
         );
 
         $c = new Controller\DiscoController($this->config, $this->session);
diff --git a/tests/modules/saml/src/Controller/ProxyTest.php b/tests/modules/saml/src/Controller/ProxyTest.php
@@ -88,7 +88,7 @@ public function testMissingStateId(): void
     public function testWithStateId(): void
     {
         $request = Request::create(
-            '/invalidSesssion?AuthState=someState',
+            '/invalidSesssion?AuthState=_abc123',
             'POST',
         );
 
@@ -117,7 +117,7 @@ public static function loadState(string $id, string $stage, bool $allowMissing =
     public function testWithStateIdCancel(): void
     {
         $request = Request::create(
-            '/invalidSesssion?AuthState=someState',
+            '/invalidSesssion?AuthState=_abc123',
             'POST',
             ['cancel' => 'cancel'],
         );
@@ -147,7 +147,7 @@ public static function loadState(string $id, string $stage, bool $allowMissing =
     public function testWithStateIdContinue(): void
     {
         $request = Request::create(
-            '/invalidSesssion?AuthState=someState',
+            '/invalidSesssion?AuthState=_abc123',
             'POST',
             ['continue' => 'continue'],
         );
diff --git a/tests/src/SimpleSAML/XHTML/TemplateTranslationTest.php b/tests/src/SimpleSAML/XHTML/TemplateTranslationTest.php
@@ -55,7 +55,7 @@ public function testCoreLoginUserPassTemplate(): void
         $t->data['username'] = 'h.c oersted';
         $t->data['rememberUsernameEnabled'] = false;
         $t->data['rememberMeEnabled'] = false;
-        $t->data['AuthState'] = 'abc123';
+        $t->data['AuthState'] = '_abc123';
 
         $getContent = function (): string {
             /** @var \SimpleSAML\XHTML\Template $this */
