Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/python-aiplatform
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: simonhessner/python-aiplatform
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 12, 2024

  1. Bugfix: 0 is now considered a valid step number in log_time_series_me… 

    …trics

Previously, when log_time_series_metrics is called without a step value it defaults to None. The function internally checked `if not step` and
in this case, determined a step number. The problem is that 0 is falsy and therefore the function turns step=0 into step=1 which is a problem if
the function is later called with step=1 (in that case the first logged values are overwritten)

Checking for `if step is None` fixes the problem.
    @simonhessner
    simonhessner committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    f6e8a6a View commit details
    Browse the repository at this point in the history
Loading