There will be a small change to the API: we will take a reference to a padded_string, to make sure that users padded their input strings.
This is a rather unfortunate and expensive change. If I understand the interface change correctly, JsonStream parser can no longer parse insitu, but requires a byte copy. Although I am just one perspective, I think it is generally not the desired behavior when using a streaming parser.
I understand ultimately parsed data is getting written to the tape, just think requiring a padded_string json_parse method is an unnecessary copy.
Originally posted by @jmackt in #467 (comment)
This is a rather unfortunate and expensive change. If I understand the interface change correctly, JsonStream parser can no longer parse insitu, but requires a byte copy. Although I am just one perspective, I think it is generally not the desired behavior when using a streaming parser.
I understand ultimately parsed data is getting written to the tape, just think requiring a padded_string json_parse method is an unnecessary copy.
Originally posted by @jmackt in #467 (comment)