From 668f466c69e728c9a6838f2775378424f1a1d18a Mon Sep 17 00:00:00 2001 From: Eugene Fidelin Date: Wed, 29 Oct 2014 15:29:50 +0100 Subject: [PATCH 1/2] Use separate session to download assets from AWS This fixes an error "Only one auth mechanism allowed; only the X-Amz-Algorithm query parameter, Signature query string parameter or the Authorization header should be specified" --- github3/repos/release.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/github3/repos/release.py b/github3/repos/release.py index 0219c6e70..7a5dfcd68 100644 --- a/github3/repos/release.py +++ b/github3/repos/release.py @@ -1,6 +1,7 @@ # -*- coding: utf-8 -*- from __future__ import unicode_literals import json +import requests from ..decorators import requires_auth from ..models import GitHubCore, GitHubError @@ -188,7 +189,7 @@ def download(self, path=''): 'Authorization': None, 'Content-Type': None, }) - resp = self._get(resp.headers['location'], stream=True, + resp = requests.Session().get(resp.headers['location'], stream=True, headers=headers) if self._boolean(resp, 200, 404): From 54f7182efb83dc01eeeec67387afde1a3a420b72 Mon Sep 17 00:00:00 2001 From: Eugene Fidelin Date: Wed, 29 Oct 2014 16:17:41 +0100 Subject: [PATCH 2/2] Use separate GitHubSession() to download assets from AWS --- github3/repos/release.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/github3/repos/release.py b/github3/repos/release.py index 7a5dfcd68..7fd2fb40f 100644 --- a/github3/repos/release.py +++ b/github3/repos/release.py @@ -1,8 +1,8 @@ # -*- coding: utf-8 -*- from __future__ import unicode_literals import json -import requests +from ..session import GitHubSession from ..decorators import requires_auth from ..models import GitHubCore, GitHubError from ..utils import stream_response_to_file @@ -189,7 +189,7 @@ def download(self, path=''): 'Authorization': None, 'Content-Type': None, }) - resp = requests.Session().get(resp.headers['location'], stream=True, + resp = GitHubSession().get(resp.headers['location'], stream=True, headers=headers) if self._boolean(resp, 200, 404):