Skip to content

Commit f16adae

Browse files
dandavisondandavison
committed
Unskip update tests under java test server
1 parent 8903768 commit f16adae

3 files changed

Lines changed: 8 additions & 45 deletions

File tree

‎tests/hello/hello_update_test.py‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
import uuid
22

3-
import pytest
43
from temporalio.client import Client, WorkflowExecutionStatus
5-
from temporalio.testing import WorkflowEnvironment
64
from temporalio.worker import Worker
75

86
from hello.hello_update import GreetingWorkflow
97

108

11-
async def test_update_workflow(client: Client, env: WorkflowEnvironment):
12-
if env.supports_time_skipping:
13-
pytest.skip(
14-
"Time-skipping test server currently has issue with update: https://github.com/temporalio/sdk-java/issues/1903"
15-
)
9+
async def test_update_workflow(client: Client):
1610
task_queue_name = str(uuid.uuid4())
1711
async with Worker(client, task_queue=task_queue_name, workflows=[GreetingWorkflow]):
1812
handle = await client.start_workflow(

‎tests/message_passing/introduction/test_introduction_sample.py‎

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import pytest
44
from temporalio.client import Client, WorkflowUpdateFailedError
5-
from temporalio.testing import WorkflowEnvironment
65
from temporalio.worker import Worker
76

87
from message_passing.introduction.starter import TASK_QUEUE
@@ -14,11 +13,7 @@
1413
)
1514

1615

17-
async def test_queries(client: Client, env: WorkflowEnvironment):
18-
if env.supports_time_skipping:
19-
pytest.skip(
20-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
21-
)
16+
async def test_queries(client: Client):
2217
async with Worker(
2318
client,
2419
task_queue=TASK_QUEUE,
@@ -46,11 +41,7 @@ async def test_queries(client: Client, env: WorkflowEnvironment):
4641
]
4742

4843

49-
async def test_set_language(client: Client, env: WorkflowEnvironment):
50-
if env.supports_time_skipping:
51-
pytest.skip(
52-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
53-
)
44+
async def test_set_language(client: Client):
5445
async with Worker(
5546
client,
5647
task_queue=TASK_QUEUE,
@@ -69,11 +60,7 @@ async def test_set_language(client: Client, env: WorkflowEnvironment):
6960
assert await wf_handle.query(GreetingWorkflow.get_language) == Language.CHINESE
7061

7162

72-
async def test_set_invalid_language(client: Client, env: WorkflowEnvironment):
73-
if env.supports_time_skipping:
74-
pytest.skip(
75-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
76-
)
63+
async def test_set_invalid_language(client: Client):
7764
async with Worker(
7865
client,
7966
task_queue=TASK_QUEUE,
@@ -92,17 +79,11 @@ async def test_set_invalid_language(client: Client, env: WorkflowEnvironment):
9279
)
9380

9481

95-
async def test_set_language_that_is_only_available_via_remote_service(
96-
client: Client, env: WorkflowEnvironment
97-
):
82+
async def test_set_language_that_is_only_available_via_remote_service(client: Client):
9883
"""
9984
Similar to test_set_invalid_language, but this time Arabic is available
10085
since we use the remote service.
10186
"""
102-
if env.supports_time_skipping:
103-
pytest.skip(
104-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
105-
)
10687
async with Worker(
10788
client,
10889
task_queue=TASK_QUEUE,

‎tests/message_passing/safe_message_handlers/workflow_test.py‎

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,7 @@
2020
)
2121

2222

23-
async def test_safe_message_handlers(client: Client, env: WorkflowEnvironment):
24-
if env.supports_time_skipping:
25-
pytest.skip(
26-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
27-
)
23+
async def test_safe_message_handlers(client: Client):
2824
task_queue = f"tq-{uuid.uuid4()}"
2925
async with Worker(
3026
client,
@@ -72,11 +68,7 @@ async def test_safe_message_handlers(client: Client, env: WorkflowEnvironment):
7268
assert result.num_currently_assigned_nodes == 0
7369

7470

75-
async def test_update_idempotency(client: Client, env: WorkflowEnvironment):
76-
if env.supports_time_skipping:
77-
pytest.skip(
78-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
79-
)
71+
async def test_update_idempotency(client: Client):
8072
task_queue = f"tq-{uuid.uuid4()}"
8173
async with Worker(
8274
client,
@@ -111,11 +103,7 @@ async def test_update_idempotency(client: Client, env: WorkflowEnvironment):
111103
assert result_1.nodes_assigned >= result_2.nodes_assigned
112104

113105

114-
async def test_update_failure(client: Client, env: WorkflowEnvironment):
115-
if env.supports_time_skipping:
116-
pytest.skip(
117-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
118-
)
106+
async def test_update_failure(client: Client):
119107
task_queue = f"tq-{uuid.uuid4()}"
120108
async with Worker(
121109
client,

0 commit comments

Comments
 (0)